Fix/scripted importer axes #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
previously approved these changes
May 19, 2021
| /// </summary> | ||
| public enum ScriptedImporterAxes | ||
| { | ||
| Default, |
There was a problem hiding this comment.
モデルがそれぞれ Default の属性を持てるのはよさそう
| case ScriptedImporterAxes.X: return Axes.X; | ||
| case ScriptedImporterAxes.Default: | ||
| { | ||
| #if UNIGLTF_DEFAULT_AXES_X |
There was a problem hiding this comment.
Symbols 切り替えは（大きなプロジェクトに入ったときに）重そうではあるｗ
* symbol UNIGLTF_DEFAULT_AXES_X は止める
Santarh
previously approved these changes
May 20, 2021
There was a problem hiding this comment.
よさそう。
ただエッジケースに気づいてしまった感。
たとえばまず、GLB ファイルをプロジェクトに入れて、Default 設定として Import 。
その次にプロジェクトのデフォルト軸の設定を変更。
その状態だと、GLB ファイルは Default なのにプロジェクトの設定と食い違った状態で読み込まれているという矛盾状態。
そしてこの状態は、プロジェクトの Reimport All などが走ったタイミングで是正されて、突然軸方向が "正しくなって" しまう。
したがって次の挙動があるべきなきはする。
「プロジェクトのデフォルト軸設定を変更したとき、プロジェクトに読み込まれているすべての GLB ファイルは再インポートが走る」
Santarh
approved these changes
May 20, 2021
|
|
||
| namespace UniGLTF | ||
| { | ||
| public static class UniGLTFPreference | ||
| { | ||
| static IEnumerable<string> GetReimportPaths() | ||
| { | ||
| String[] guids = AssetDatabase.FindAssets("t:GameObject", null); |
| } | ||
| else if (AssetImporter.GetAtPath(assetPath) is GltfScriptedImporter gltf) | ||
| { | ||
| if (gltf.m_reverseAxis == ScriptedImporterAxes.Default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#940
ScriptedImporterAxes を導入して、gltf/glb のデフォルト変換軸設定の実装方法を変更した。