Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sampler param #966

Merged
merged 2 commits into from May 21, 2021
Merged

Conversation

ousttrue
Copy link
Contributor

#947

SamplerParam の改修と #if UNITY_2017_1_OR_NEWER の除去。
この PR ではここまで。

次回に、

  • mipmap関連
  • import/export 時の enum 対応表
  • asset 向け TextureImporter 周り

やります。

@ousttrue ousttrue requested a review from Santarh May 21, 2021 04:16
@@ -5,7 +5,31 @@ namespace VRMShaders
{
public struct SamplerParam
{
public (SamplerWrapType, TextureWrapMode)[] WrapModes;
public FilterMode FilterMode;
public TextureWrapMode WrapModesU;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unity-2017 から wrapmode が u, v, w に分離された様子。
最近のUniVRMは、サポートバージョンが Unity-2018 以降なので変更。

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@ousttrue ousttrue merged commit 895c488 into vrm-c:master May 21, 2021
@ousttrue ousttrue deleted the feature/sampler_param branch October 27, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants