Skip to content

Commit

Permalink
urfave/cli: fix parsing of short opts
Browse files Browse the repository at this point in the history
Vendor an updated version of urfave/cli to fix the parsing of short
options.  Until the fix is merged upstream, vendor the code from
github.com/vrothberg/cli containing both, the latest urfave/cli and
the bug fix.

Fixes: containers#714
Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
  • Loading branch information
vrothberg committed Jul 5, 2018
1 parent f2462ca commit 0b9ee59
Show file tree
Hide file tree
Showing 6 changed files with 197 additions and 61 deletions.
9 changes: 9 additions & 0 deletions test/e2e/run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ var _ = Describe("Podman run", func() {
Expect(session.ExitCode()).To(Equal(0))
})

It("podman run a container based on local image with short options and args", func() {
// regression test for #714
session := podmanTest.Podman([]string{"run", ALPINE, "find", "/", "-name", "etc"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
match, _ := session.GrepString("/etc")
Expect(match).Should(BeTrue())
})

It("podman run a container based on remote image", func() {
session := podmanTest.Podman([]string{"run", "-dt", BB_GLIBC, "ls"})
session.WaitWithDefaultTimeout()
Expand Down
2 changes: 1 addition & 1 deletion vendor.conf
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ github.com/stretchr/testify 4d4bfba8f1d1027c4fdbe371823030df51419987
github.com/syndtr/gocapability e7cb7fa329f456b3855136a2642b197bad7366ba
github.com/tchap/go-patricia v2.2.6
github.com/ulule/deepcopier master
github.com/urfave/cli 39908eb08fee7c10d842622a114a5c133fb0a3c6
github.com/urfave/cli fix-short-opts-parsing https://github.com/vrothberg/cli
github.com/vbatts/tar-split v0.10.2
github.com/vishvananda/netlink master
github.com/vishvananda/netns master
Expand Down
Loading

0 comments on commit 0b9ee59

Please sign in to comment.