Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install failed: /bin/bash: sudo: command not found #130

Closed
Whissi opened this issue Nov 1, 2020 · 3 comments · Fixed by #131
Closed

make install failed: /bin/bash: sudo: command not found #130

Whissi opened this issue Nov 1, 2020 · 3 comments · Fixed by #131

Comments

@Whissi
Copy link

Whissi commented Nov 1, 2020

Please remove sudo call in

vgrep/Makefile

Line 116 in e3a4963

sudo cp docs/*.1 ${MAN_DIR}/man1/

sudo shouldn't be used in Makefiles.

@Whissi
Copy link
Author

Whissi commented Nov 1, 2020

...and it looks like you need to create target directory first,

cp docs/*.1 /var/tmp/portage/app-text/vgrep-2.5.0/image/usr/share/man/man1/
cp: cannot create regular file '/var/tmp/portage/app-text/vgrep-2.5.0/image/usr/share/man/man1/': No such file or directory

@Whissi
Copy link
Author

Whissi commented Nov 1, 2020

--- a/Makefile
+++ b/Makefile
@@ -113,7 +113,8 @@ install: install-docs

 .PHONY: install-docs
 install-docs: docs
-       sudo cp docs/*.1 ${MAN_DIR}/man1/
+       mkdir -p ${MAN_DIR}/man1/
+       cp docs/*.1 ${MAN_DIR}/man1/

 .PHONY: uninstall
 uninstall:

is doing the job for us.

vrothberg added a commit that referenced this issue Nov 2, 2020
Use `install` and set propper permissions.

Fixes: #130
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Owner

Thanks for reaching out! This one slipped through reviewing. #131 should fix the issue.

vrothberg added a commit that referenced this issue Nov 4, 2020
Use `install` and set propper permissions.

Fixes: #130
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants