Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature suggestion: Search for products by name #43

Closed
Erik142 opened this issue Sep 9, 2021 · 1 comment · Fixed by #44
Closed

feature suggestion: Search for products by name #43

Erik142 opened this issue Sep 9, 2021 · 1 comment · Fixed by #44

Comments

@Erik142
Copy link
Contributor

Erik142 commented Sep 9, 2021

Hi again,

I believe that it would be beneficial to be able to search for products by name and get information back, including the item number for the product. I have a first implementation ready for this feature if it is of any interest to this project?

I have only tested it on the Swedish version of the corresponding IKEA API. However, the API seems to follow the same "region naming scheme" as the existing API endpoints in this project, so I believe that it should work in the same way for other regions. Let me know if this sounds interesting. If so, I'll add a PR for this 😄
@vrslev
Copy link
Owner

vrslev commented Sep 10, 2021

Hello! Sure, go ahead!

@Erik142 Erik142 mentioned this issue Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add search functionality Erik142/ikea-api-client
2 participants
@Erik142 @vrslev