This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Add search functionality #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way to assign a string with value None in python, use empty string to check whether or not a token should be set.
The Search class is used to search the IKEA product catalog by product name
Update README.md with a description on how to use the product search functionality
|
I realised that I forgot to update the readme. I will update it ASAP and commit. Sorry about that! |
|
Sorry for delay, I will look into this as soon as I can. |
vrslev
reviewed
Sep 19, 2021
|
I will make changes myself. |
- Drop `_search` function - Fix "" and None token values - Add types param - Rename `amount` param to `limit` - Return full response - Add typing_extensions to deps
|
Just added commit. Does it looks good to you? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
These changes implement search functionality for the IKEA product catalog by product name. Search is accessed through a property within the IkeaApi class. The implementation is kept in a separate class within "endpoints".
One minor change has been made to the API class to accomodate API requests without a Bearer token, since the search API doesn't use one.
Tested using the Swedish API, it works fine for me. Let me know if any further changes are required from my end.
Thanks!