Runtime zip files not unzipping

[mikewl]

When installing the vsClojure extension, the zip files in the runtimes folder do not unzip.
Microsoft.VisualStudio.Package.LanguageService.10.0.dll is present in the Extensions/[Random Letters/ folder.

Visual studio 2013 and sql server express 2014 ctp2 are installed on window 8.1 x64.

[frankhale]

Hi Mike,

Do you see this behavior with the latest version from the Visual Studio gallery? Or from the code here on Github?

[mikewl]

The latest version from the Visual Studio Gallery, I built it myself with the same issue however. Will rebuild and check again.

[frankhale]

Okay, Thank you!

On Mon, Dec 30, 2013 at 5:03 PM, Michael Wallace Louwrens <
notifications@github.com> wrote:

The latest version from the Visual Studio Gallery

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/136#issuecomment-31371691
.

[mikewl]

I built it and checked. Both the ones stored in 12.0Exp and 12.0 don't unzip, the languageservice dll is present however.

[frankhale]

What is in the following folder on your system? Is it completely empty?

C:\Users\<your_user_name>\AppData\Local\Microsoft\VisualStudio\12.0\Extensions\<random_dir_name>\Runtimes

[mikewl]

ClojureCLR-1.5.0.zip
ClojureScript-1.5.0.zip

These are in the Runtimes folder

[frankhale]

Okay, just confirming. Those two zips should not even exist there. They
should definitely be unzipped. Why was this closed?

On Tue, Dec 31, 2013 at 5:06 AM, Michael Wallace Louwrens <
notifications@github.com> wrote:

Closed #136 #136.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/136
.

[mikewl]

I seem to have confused closing the editbox with closing the issue sorry!

[frankhale]

Is .NET 3.5 installed on your machine?

[frankhale]

Did not mean to close this. Fat fingers! ARGH!

[mikewl]

Glad to see I am not the only one who mis clicks! It is not installed, it is busy installing (and has been for awhile now thanks to the slow internet.) Will update as soon as it is installed.
EDIT: All of the projects target .NET 4, so not sure of how much of an effect this will have.

[mikewl]

Strange, it works!
It now leaves an error on start however,
"ShowClojureProjectMenuCommands: Value cannot be null. Parameter name: path1"

Any idea on what is going on there?

The Clojure.dll reference does not work however, is this intended?

[frankhale]

Sorry, that was a debug statement that I inserted in a try/catch block.
Ignore it. I thought I removed that. I'll go back and check.

On Wed, Jan 8, 2014 at 12:44 PM, Michael Wallace Louwrens <
notifications@github.com> wrote:

Strange, it works!
It now leaves an error on start however,
"ShowClojureProjectMenuCommands: Value cannot be null. Parameter name:
path1"

Any idea on what is going on there?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/136#issuecomment-31858652
.

[mikewl]

I can't compile anything now. Though I can successfully create a project now. It also does the intended restart. The Clojure.dll reference doesn't function. It can't find the .dll

[mikewl]

This is the new error on startup now.

[frankhale]

I can't see the screenshot.

[mikewl]

Excuse my internet being silly

[speige]

The exception you caused makes sense as to why the runtime wasn't unzipped.

The method ShowClojureProjectMenuCommands() is called before UnzipRuntimes() in ClojurePackage.cs

Because the null value is in Path.Combine of that method, I think the issue is the Utilities.EnvironmentVariables.VsClojureRuntimesDir. This environment variable isn't set until later in the EnableSettingOfRuntimePathForNewClojureProjects() method.

The strange thing is, this should be failing for everyone. I've brand virtual machines with clean installs and haven't seen this. I wonder if it's an issue with the current GitHub commit & not with the uploaded visual studio extension? I'll investigate this a bit more tonight.

Fyi, the normal installation process (which i see on my clean VM when using the gallery version) show be like this:
Visual Studio makes you restart 2X after installing vsClojure. The 1st is from inside the the tools/extensions window after vsClojure downloads & installs. At this point, you should see .zip files in your runtimes folder. When you click restart, visual studio should auto-restart. When visual studio finishes loading after the restart, the .zip files should have been unzipped. You'll know it's done because you'll see a popup message box which asks you to restart & asks if you want to see the readme. This time, you'll have to manually restart.

I'll rearrange the environment variable code & we'll see if that makes a difference for you.

Sorry about the long wait on this issue, I'll try to be more prompt in the future.

[frankhale]

I'm pretty sure he also tried the one from the gallery and reported the same issue.

[speige]

I committed a change that might fix this unzipping issue. Do you want to pull the latest from GitHub, compile, and try it out? Alternatively, I can put the .vsix online somewhere.