Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language & grammar wiring support in extension manifest #32

Closed
wants to merge 7 commits into from
Closed

Add language & grammar wiring support in extension manifest #32

wants to merge 7 commits into from

Conversation

zm-cttae
Copy link
Member

@zm-cttae zm-cttae commented Apr 30, 2023 •
edited
Loading

From GitLab on Feb 25, 2023, 19:33

🏗️ Pull Request

  • Used a clear / meaningful title for this pull request.
  • Tested the changes on your own grammar (on your projects).
  • Added / Edited tests to reflect changes (test folder).
  • Have read the Contributing part of the README.
  • Passed npm test.
  • I noted my changes in the pull request body and/or changelog.

👷🏾‍♀️ Fixes

Related to #15.

Description

Introducing support for tokenizing and fetching dumped documents.

What changes have you made?

Add package-specific textmate-languageservice-contributes property for wiring a language and its grammar.

What tests have you completed?

  • Tested this in Visual Studio Code v1.75.1.
  • Tested this in Visual Studio Code Insiders v1.76.0.
  • Tested this in GitHub Codespaces v1.76.0.
  • Tested this in VSCodium v1.75.1.

Anything else worth mentioning?

Seems like we can switch global object to TextmateLanguageService without much fuss.

@zm-cttae zm-cttae added this to the 1.2.0 milestone Apr 30, 2023
@zm-cttae
Copy link
Member Author

zm-cttae commented Apr 30, 2023 •
edited
Loading

mentioned in commit b6fd149

@zm-cttae zm-cttae closed this Apr 30, 2023
@zm-cttae zm-cttae deleted the feat-tokenization-without-contribution branch September 9, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zm-cttae