-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing in larger files is way too slow because of syntax highlighting lexer speed. #19
Comments
Did a test with syntax highlighting using a plain text lexer. Typing issues resolved and Psi parsing is not affected. This means that doing syntax highlighting with external annotator will do the trick and will not affect typing speed like the current implementation does. |
Temporary fix added option into preferences to turn off syntax highlighting. Annotations remain but this allows faster typing when in creative mode vs validation mode. |
The issue is now less severe with threading issues addressed. I will be implementing an external annotator which delays syntax highlighting until a later update phase. It will also allow more complex, layered attributes that lexer based syntax highlighting does not handle. I will have to make the two syntax highlighting methods as options because only lexer based highlighting works in preferences color settings. |
External annotator based syntax highlighting is now the defeault. |
|
This is caused the by the lexer using pegdown for parsing and then generating lexer tokens based on the AST returned by pegdown.
Need to restore syntax highlighting for files back to using Annotator while leaving the lexer strictly for color setup sample document.
Annotator should reset attributes and provide new ones for syntax highlighting. This way the lexing will not affect typing speed and added benefit is that attributes will be combined as they were before lexer was added for syntax highlighting.
The text was updated successfully, but these errors were encountered: