The extensions is always asking for a Restart when having a workspace customization

[robertohuertasm]

VSCode: 1.13.1 & 1.14.0-insider

Since 7.10.0 has been published it seems that we introduced some kind of bug and the extension is always asking me for a restart when I'm working in my Angular project.

This doesn't happen in any other kind of projects.

I think the project detection system is messing with the manual change detection in the settings.

For the moment, I have to completely disable the new feature 😢

It's strange because I never observed this behavior when developing or testing.

[JimiC]

Any reproduction steps? I will also need the current settings.

[robertohuertasm]

I just open the angular project and start into a restart loop without end. The weird thing is I open the same exact project while debugging the extension and it doesn't ask for a restart.

At the moment this is all the information I have. I'll check it out again tonight if I find some quiet moment.

[robertohuertasm]

I've tested with a Nativescript project (which uses Angular) and I'm not having the issue so must be something specific about my project.

[JimiC]

OK then. The debugging of the issue is all yours. 😄

[robertohuertasm]

It seems that in order to reproduce this you have to have some icon customizations in your workspace settings:

"vsicons.associations.files": [
    { "icon": "karma",  "extensions": ["karma.conf.gitlab.js"], "filename": true, "format": "svg" }
  ]

[robertohuertasm]

Indeed, it is not only affecting Angular projects but any project with workspace or user icon customizations.

[rnemec]

Confirming here too: icon customizations in workspace settings => "Restart" looping.

[robertohuertasm]

@rnemec, @JimiC already provided a fix. We'll be publishing it tomorrow.

[rnemec]

@robertohuertasm - thank you. I guess you have it fully under control now, but FYI an additional test case is editing workspace settings - each Save triggers that "Reload" popup.

[robertohuertasm]

@JimiC, it seems that it's still not working. I've just tested it before publishing but I keep receiving the same error.

[robertohuertasm]

Fixed it in latest PR. Already published.