Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart loop issue with manual config changes detection. #1043

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jun 26, 2017

Fixes #1042

Changes proposed:

  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue

@JimiC JimiC added this to the Next milestone Jun 26, 2017
@JimiC
Copy link
Member Author

JimiC commented Jun 26, 2017

The issue was caused because the manual config changes detection doesn't take into account the merged config settings. My original intention was to include that (after it was merged) but forgot to do so with all the fuzz going around.

@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #1043 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1043   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2255    2255           
  Branches      109     109           
======================================
  Hits         2255    2255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1564570...8041f34. Read the comment docs.

@robertohuertasm robertohuertasm merged commit 0805096 into vscode-icons:master Jun 26, 2017
@JimiC JimiC deleted the fix_restart_loop branch June 27, 2017 12:47
@robertohuertasm robertohuertasm modified the milestones: 7.10.0, 7.11.0 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The extensions is always asking for a Restart when having a workspace customization
3 participants