Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for perl is too dark for a dark theme. #2300

Closed
1 of 2 tasks
carlosfrodriguez opened this issue Nov 28, 2019 · 12 comments · Fixed by #2305
Closed
1 of 2 tasks

Icon for perl is too dark for a dark theme. #2300

carlosfrodriguez opened this issue Nov 28, 2019 · 12 comments · Fixed by #2305
Assignees

Comments

@carlosfrodriguez
Copy link

  • I'm sure this issue is not a duplicate.

  • I'm submitting an icon request:

  • Language Extensions: pl, pm, t

  • More info: The icon is too dark for for a dark theme

Screen Shot 2019-11-28 at 12 30 01 PM

@KingDarBoja
Copy link
Member

@JimiC Maybe we could provide a light version for the Perl Camel but use some kind of light colour and not just a slight white gray.

@JimiC
Copy link
Member

JimiC commented Nov 29, 2019

That's the official color. Does it have also a light version?

@KingDarBoja
Copy link
Member

@JimiC Not sure as the Camel is a trademark of O'Reilly in association with Perl.

Source: The Perl Camel

I don't see anything that block us to provide a light version as long as we respect the trademark guidelines:

"Color guidelines: The details and outlines of the animals always appear darker than
the background color, i.e., they may not be reversed. If they are to appear on a dark
color, they may be masked precisely with white, with the animal graphic overlaid in a
darker color. Any use of the animals in colors other than their appearance on the
book covers must be approved in advance by O’Reilly Media, Inc."

@carlosfrodriguez
Copy link
Author

@KingDarBoja That are good news, I will be looking forward for the new icon :-)

@JimiC
Copy link
Member

JimiC commented Nov 29, 2019

Read the guidelines again. The animal color has to be always dark even in dark themes.

If they are to appear on a dark color, they may be masked precisely with white, with the animal graphic overlaid in a darker color.

@JimiC
Copy link
Member

JimiC commented Nov 29, 2019

Maybe it's best to get away from the camel icon and use a literal perl icon.

@carlosfrodriguez
Copy link
Author

@JimiC That would be also acceptable, to have the onion icon instead of the camel

@JimiC
Copy link
Member

JimiC commented Nov 29, 2019

Onion icon is already supported. You only need to enable it.

@carlosfrodriguez
Copy link
Author

@JimiC I will try, let me read how to do it, but from https://github.com/vscode-icons/vscode-icons/wiki/ListOfFiles , it also looks very dark.

@carlosfrodriguez
Copy link
Author

@JimiC I was able to test it and yes it look better, but sill too dark, if a lighter version could be added it will be great

@JimiC
Copy link
Member

JimiC commented Nov 29, 2019

As I said we can't deviate from official guidelines. Your only option is to use the customization feature and use your own icon.

@KingDarBoja
Copy link
Member

KingDarBoja commented Nov 30, 2019

Read the guidelines again. The animal color has to be always dark even in dark themes.

If they are to appear on a dark color, they may be masked precisely with white, with the animal graphic overlaid in a darker color.

With mask they refer to add a outline to the logo or what? Because that's what I have on mind.

UPDATE
A subtle change as the icon already has an outline path. However the final result is not what I expected.
Perl Camel A

So I went with my own outline and got my desired effect:
Perl Camel B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants