Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light version of Perl camel #2305

Merged

Conversation

KingDarBoja
Copy link
Member

Fixes #2300

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@KingDarBoja KingDarBoja requested a review from a team December 5, 2019 23:46
Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since you are adding a white mask the light version is not needed.
  2. I'm not satisfied with the way the mask is added.

@KingDarBoja
Copy link
Member Author

@JimiC Any suggestion on how to add the mask? I do feel it follows the guidelines provided by the Perl / O'Reilly Foundation.

@JimiC
Copy link
Member

JimiC commented Dec 23, 2019

It requires me to fire up my design software and as I don't have a working machine atm this will have to wait.

@robertohuertasm
Copy link
Member

@JimiC could you be more specific about what exactly doesn't feel right with the light version? Is it the thickness of the contour line?

@JimiC
Copy link
Member

JimiC commented Dec 23, 2019

Basically we don't need a light version. The icon is visible enough in light themes. The issue reported is with dark themes. And since we adding the mask it can be used in any theme.

@robertohuertasm
Copy link
Member

Sorry, I said light instead of dark. So, if I'm getting this right, your suggestion would be to use the same icon (the one with the outline) for both kind of themes?

@JimiC
Copy link
Member

JimiC commented Dec 23, 2019

Yes. The concern is that some details of the icon are getting overlapped by the mask. But I could revise the icon on a later time (if I remember to do it).

@KingDarBoja
Copy link
Member Author

KingDarBoja commented Dec 23, 2019

I could try to revise the icon as soon as possible, probably on this weekend.

And you're right, I should not have provided both dark and light version as the outline does the job. However, the outline was already part of the icon but filled with the purple color instead.

@KingDarBoja
Copy link
Member Author

@JimiC @robertohuertasm Just to save you some time, here is the Perl icon on full size

Perl Camel

The gray outline was the same color as the camel on the original icon.

@robertohuertasm robertohuertasm modified the milestones: Backlog, Next Dec 26, 2019
@robertohuertasm robertohuertasm merged commit 0d1fa5b into vscode-icons:master Feb 15, 2020
@KingDarBoja KingDarBoja deleted the enhancement/perl-camel-light branch February 15, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for perl is too dark for a dark theme.
3 participants