-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light version of Perl camel #2305
Add light version of Perl camel #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since you are adding a white mask the light version is not needed.
- I'm not satisfied with the way the mask is added.
@JimiC Any suggestion on how to add the mask? I do feel it follows the guidelines provided by the Perl / O'Reilly Foundation. |
It requires me to fire up my design software and as I don't have a working machine atm this will have to wait. |
@JimiC could you be more specific about what exactly doesn't feel right with the light version? Is it the thickness of the contour line? |
Basically we don't need a light version. The icon is visible enough in light themes. The issue reported is with dark themes. And since we adding the mask it can be used in any theme. |
Sorry, I said |
Yes. The concern is that some details of the icon are getting overlapped by the mask. But I could revise the icon on a later time (if I remember to do it). |
I could try to revise the icon as soon as possible, probably on this weekend. And you're right, I should not have provided both dark and light version as the outline does the job. However, the outline was already part of the icon but filled with the purple color instead. |
@JimiC @robertohuertasm Just to save you some time, here is the Perl icon on full size The gray outline was the same color as the camel on the original icon. |
Fixes #2300
Changes proposed: