Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Review and fix files declaration #424

Closed
1 task done
JimiC opened this issue Nov 6, 2016 · 6 comments · Fixed by #426 or #430
Closed
1 task done

[Task] Review and fix files declaration #424

JimiC opened this issue Nov 6, 2016 · 6 comments · Fixed by #426 or #430

Comments

@JimiC
Copy link
Member

JimiC commented Nov 6, 2016

Checklist:

  • I'm sure this issue is not a duplicate?

Currently, some file declarations are incorrect. (i.e. .editorconfig is a configuration file with no extension, and has been declared as a file extension).

Task assignment:
Go through all entries in supportedExtensions.js and correct the file declaration.

@JimiC
Copy link
Member Author

JimiC commented Nov 6, 2016

This is just a placeholder issue for the PR I'm gonna submit (sometime until next weekend, I hope).

@JimiC
Copy link
Member Author

JimiC commented Nov 6, 2016

@robertohuertasm

I see some entries like

    { icon: 'bower', extensions: ['bowerrc'], contribType: ctype.filename },
    { icon: 'bower', extensions: ['bower.json'], contribType: ctype.filename },

can they be concatenated to a one line declaration, like
{ icon: 'bower', extensions: ['bowerrc', 'bower.json'], contribType: ctype.filename }
?

@JimiC
Copy link
Member Author

JimiC commented Nov 6, 2016

@robertohuertasm I think I have answered my own question. I figured that if two filenames have the same icon and one filename has an extension, but still belongs to the fileNames group, it gets declared on a new line.

@robertohuertasm
Copy link
Member

@JimiC those entries should be merged into one. This is a legacy issue. We just removed the old custom funcionality and before we needed to separate the different filenames into different entries in order to generate our custom replacements.

As this is now not needed at all, we may have several cases like this where we could merge several entries into one. If they all are filenames or fileextensions then can be declared as one entry.

@JimiC
Copy link
Member Author

JimiC commented Nov 6, 2016

@robertohuertasm Good to know. What about those with contribOrder?

@robertohuertasm
Copy link
Member

contribOrder was used to bypass a bug in VSCode icon theming functionality. It seems that it's already solved so I guess we can get rid of it. I'm going to do it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants