-
-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Review and fix files declaration #424
Comments
This is just a placeholder issue for the PR I'm gonna submit (sometime until next weekend, I hope). |
I see some entries like
can they be concatenated to a one line declaration, like |
@robertohuertasm I think I have answered my own question. I figured that if two filenames have the same icon and one filename has an extension, but still belongs to the |
@JimiC those entries should be merged into one. This is a legacy issue. We just removed the old custom funcionality and before we needed to separate the different filenames into different entries in order to generate our custom replacements. As this is now not needed at all, we may have several cases like this where we could merge several entries into one. If they all are |
@robertohuertasm Good to know. What about those with |
contribOrder was used to bypass a bug in VSCode icon theming functionality. It seems that it's already solved so I guess we can get rid of it. I'm going to do it right now. |
Checklist:
Currently, some file declarations are incorrect. (i.e.
.editorconfig
is a configuration file with no extension, and has been declared as a file extension).Task assignment:
Go through all entries in
supportedExtensions.js
and correct the file declaration.The text was updated successfully, but these errors were encountered: