Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile as a extension #430

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Dockerfile as a extension #430

merged 1 commit into from
Nov 6, 2016

Conversation

robertohuertasm
Copy link
Member

@robertohuertasm robertohuertasm commented Nov 6, 2016 •
edited

Fixes #424

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • I've pulled the latest master branch.
  • I've run npm install to install all the dependencies.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • I've run npm run build to build the extension.

@robertohuertasm robertohuertasm merged commit e4c656f into master Nov 6, 2016
@robertohuertasm robertohuertasm deleted the fix-contriborder branch November 6, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Review and fix files declaration
1 participant
@robertohuertasm