Return old nice JS icon!

[ghost]

Please, i very like your extension but new JS icon you made (latest version) make my eyes a little bleeding.
Give us back old good intelligent JS icon please :-)
P.S. I have light theme.

[robertohuertasm]

Here we go again! #508, #339 & #354.

Thanks @VitalySenko for your opinion. We'll have to start a debate on this. What I know is that at some point any decision we make is not going to please everybody. Let's see what people says in this thread.

Anyway, I'm starting to work in a new functionality that will allow more customization options to the extension. It's just raw material for the moment but I expect to have it soon. By now, just a PoC.

[JimiC]

Been there, done that. It's a non ending story. Would a poll do the trick?

[solomon23]

Using the dark theme it's the brightest thing on my screen now. Large blocks of yellow for js files. Maybe supporting themes would be a good way to solve it ? Right now I'll probably have to turn it off.

[robertohuertasm]

@solomon23 what do you mean with supporting themes? VSCode api is what it is and doesn't really allow any kind of customization by the user. Their solution is to create an alternative theme, but there are already other themes in the market that provide slightly different icons (a lot of them are feeding from our repo).

I was reluctant to change JS and TS icons at the beginning but now I think I like how they look like. I intend to keep this thread open and see which are the opinions of users, although I guess this will be biased to the don't like feeling.

I've asked among my fellow colleagues and they all seem to like it but everything is susceptible of being discussed.

[solomon23]

@robertohuertasm apologies, i can't really speak intelligently about solutions since i'm not really familiar with it. The new yellow JS icon is garish enough that I had to turn it off since it's too distracting to my workspace. Luckily for me there are other icon choices out there for me, so I'll just use one of those. Thanks !

[robertohuertasm]

@solomon23 no worries. I understand that pleasing everybody is an impossible mission. Anyway, I will try a new set of icons playing with inversion of colors (that was the idea behind the old icons) and hopefully will find a way for the user to decide which one to use (although I can't promise you anything).

[JohhnyP]

It's not about pleasing everybody in this case, since many users are using a dark theme placing a light yellow block as an icon it's a debatable choice at best.
Isn't there a way to manually override it at the moment?

[robertohuertasm]

@JohhnyP, no overriding options at the moment 😞 In fact, VSCode API doesn't allow any user decision at all.

[JohhnyP]

Sadface.
Ok, looking forward to your changes that will allow to revert or customize the icons.
Also i'm attaching a screenshot to check how distracting the new icon is on a .js-heavy project.

[robertohuertasm]

Maybe this weekend I'll have time but I can't promise you anything.
The thing is that I kind of like it although I was myself reluctant to adopt this icon at first, but as I said before, everybody has its own opinion on subjective matters.

[JimiC]

On a survey among colleagues, the answers were in favor of the new icon.
As Roberto said, we won't get any positive feedback in this thread.

Now on the front on how to provide a way to customize the icons, I have an idea but I first would like to discuss this in private with Roberto.

So @robertohuertasm when you find the time please email me (email is on my profile).

[robertohuertasm]

Same situation in my workplace. @JimiC I'm currently working on this but I'll be happy to discuss it with you. I was considering to create a slack channel or something for us to communicate faster and privately if we want.

[JimiC]

👍 on slack. Skype will suffice too.

[FDMatthias]

I've been using vscode very early on, and vscode icons when it had like 13k downloads so I've seen the progress, which I thank you guys for very much! But when I updated the extension today and saw all that yellow across my screen I died a bit inside.

@JohhnyP Same here:

So yeah, please provide a way so we can choose the icon or something please :)

thanks!

[JimiC]

Just FYI. @robertohuertasm and I are looking into providing a way so you can configure each icon.

So until this happens

[supoved]

+1 to revert icon, or being able to opt out of it in configuration.