Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Icon Matching Is Too Broad #538

Closed
Tsmith18256 opened this issue Dec 16, 2016 · 2 comments · Fixed by #596
Closed

Angular Icon Matching Is Too Broad #538

Tsmith18256 opened this issue Dec 16, 2016 · 2 comments · Fixed by #596
Assignees

Comments

@Tsmith18256
Copy link

The new Angular icons are nice, but the matching pattern is too hit and miss that I think there should be an option to disable these. I have a React Native project in which I end all my React Component files with .component.js, so they are being marked as Angular files.

Additionally, in my project at work, where we use Angular 1, the controllers are marked as .controller.js and don't get the Angular icon. The Angular icons are a good idea, but it's confusing right now seeing them where they shouldn't be and missing where they should be.

@Tsmith18256
Copy link
Author

I apologize if this is ignorant (I know pretty much nothing about the VSCode extension API), but is there any chance it would be possible to have a config where users could map their own regexes to different icons?

@JimiC
Copy link
Member

JimiC commented Dec 16, 2016

See #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants