Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support package-lock.json generated by npm5 #953

Closed
lekhnath opened this issue May 28, 2017 · 4 comments · Fixed by #954
Closed

Support package-lock.json generated by npm5 #953

lekhnath opened this issue May 28, 2017 · 4 comments · Fixed by #954
Assignees
@jens1o
Labels
file icons
Milestone
7.8.0

Comments

@lekhnath
Copy link

Please provide some icon for this file.
@JimiC JimiC added this to the Backlog milestone May 28, 2017
@jens1o
Copy link
Member

jens1o commented May 28, 2017

Are you fine with the normal npm icon?

@JimiC
Copy link
Member

JimiC commented May 28, 2017

@jens1o Yeap that is the intention. Can you provide a PR?

@lekhnath
Copy link
Author

Yes npm icon would be great.

@jens1o
Copy link
Member

jens1o commented May 28, 2017

Of course 😋

@jens1o jens1o self-assigned this May 28, 2017
@jens1o jens1o mentioned this issue May 28, 2017
Merged
5 tasks
@robertohuertasm robertohuertasm modified the milestones: Backlog, 7.8.0 May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jens1o jens1o

Labels
file icons
Projects
None yet
Milestone
7.8.0
Development

Successfully merging a pull request may close this issue.

support package-lock.json vscode-icons/vscode-icons
4 participants
@robertohuertasm @JimiC @lekhnath @jens1o