Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1064

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jul 9, 2017

Updating dependencies, excluding @types/node, until releases reaches stability.

Also, fixes issue with using valudio as npm package registry.
@robertohuertasm we should avoid using it.

@jens1o jens1o added this to the Next milestone Jul 9, 2017
@JimiC JimiC requested a review from a team July 9, 2017 18:31
@jens1o
Copy link
Member

jens1o commented Jul 9, 2017

Are we sure we're releasing in more than a week?

@JimiC
Copy link
Member Author

JimiC commented Jul 9, 2017

We better merge this PR now as it contains fixes to the broken build, updates to tslint and ts as well, which improves our code quality.

@codecov
Copy link

codecov bot commented Jul 9, 2017

Codecov Report

Merging #1064 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1064   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2256    2256           
  Branches      109     109           
======================================
  Hits         2256    2256
Impacted Files Coverage Δ
src/utils/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f76c5...f6ea60c. Read the comment docs.

@robertohuertasm
Copy link
Member

Sorry, I use a private npm as default and I didn't take it into account when I last updated the package-lock.json file.

@JimiC
Copy link
Member Author

JimiC commented Jul 10, 2017

The issue was with yarn not so much with npm.

@robertohuertasm robertohuertasm merged commit dba6438 into vscode-icons:master Jul 10, 2017
@JimiC JimiC deleted the update_dependencies branch July 10, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants