Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CHANGELOG link #1107

Merged
merged 2 commits into from
Jul 30, 2017
Merged

Correct CHANGELOG link #1107

merged 2 commits into from
Jul 30, 2017

Conversation

LaurentTreguier
Copy link
Contributor

@LaurentTreguier LaurentTreguier commented Jul 29, 2017 •
edited

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

There was simply an incorrect link in CHANGELOG.md.

jens1o
jens1o approved these changes Jul 29, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@codecov
Copy link

codecov bot commented Jul 29, 2017 •
edited

Codecov Report

Merging #1107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1107   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          49      49           
  Lines        2384    2384           
  Branches      115     115           
======================================
  Hits         2384    2384

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c493587...e4c5033. Read the comment docs.

@JimiC JimiC added this to the Next milestone Jul 30, 2017
@robertohuertasm robertohuertasm merged commit c227844 into vscode-icons:master Jul 30, 2017
@robertohuertasm robertohuertasm modified the milestones: 7.12.0, Next Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

@JimiC JimiC JimiC approved these changes

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LaurentTreguier @robertohuertasm @JimiC @jens1o