Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added eslintcache #1135

Merged
merged 2 commits into from
Aug 30, 2017
Merged

Added eslintcache #1135

merged 2 commits into from
Aug 30, 2017

Conversation

eddiemoore
Copy link
Contributor

Fixes #1134

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

[short comment]
Adding .eslintcache file to eslint and eslint2 supported extensions

@codecov
Copy link

codecov bot commented Aug 18, 2017 •
edited

Codecov Report

Merging #1135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1135   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          49      49           
  Lines        2384    2384           
  Branches      115     115           
======================================
  Hits         2384    2384
Impacted Files Coverage Δ
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a91ca8...1ef71cf. Read the comment docs.

jens1o
jens1o approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@robertohuertasm robertohuertasm merged commit 5ec680d into vscode-icons:master Aug 30, 2017
@eddiemoore eddiemoore deleted the fix/eslint-cache branch August 30, 2017 23:04
@robertohuertasm robertohuertasm added this to the Next milestone Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

@JimiC JimiC JimiC approved these changes

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.13.0
Development

Successfully merging this pull request may close these issues.

[Icon Request] ESLint cache
4 participants
@eddiemoore @robertohuertasm @JimiC @jens1o