Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for QSharp #1518

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Add support for QSharp #1518

merged 2 commits into from
Mar 18, 2018

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Mar 17, 2018

Fixes #1497

Changes proposed:

  • Add

@JimiC JimiC added this to the Next milestone Mar 17, 2018
@JimiC JimiC requested a review from a team March 17, 2018 13:33
@codecov
Copy link

codecov bot commented Mar 17, 2018 •
edited

Codecov Report

Merging #1518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1518   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2626    2621    -5     
  Branches      133     133           
======================================
- Hits         2626    2621    -5
Impacted Files Coverage Δ
src/icon-manifest/languages.ts 100% <ø> (ø) ⬆️
src/icon-manifest/supportedExtensions.ts 100% <ø> (ø) ⬆️
test/iconGenerator/functionality.test.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d88ea...366a130. Read the comment docs.

jens1o
jens1o previously approved these changes Mar 17, 2018
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that this even exists.

@robertohuertasm robertohuertasm dismissed stale reviews from jens1o and themself via 366a130 March 18, 2018 16:04
@robertohuertasm robertohuertasm merged commit 5ef0850 into vscode-icons:master Mar 18, 2018
@JimiC JimiC deleted the support_qsharp branch March 18, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm left review comments

@jens1o jens1o jens1o left review comments

Assignees
No one assigned
Labels
file icons
Projects
None yet
Milestone
7.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JimiC @robertohuertasm @jens1o