Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code-climate config file #1624

Merged
merged 2 commits into from Jun 17, 2018
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jun 12, 2018

Note: Required tokens for test coverage have already been set in both CI services.

@JimiC JimiC added the devops label Jun 12, 2018
@JimiC JimiC added this to the Next milestone Jun 12, 2018
@JimiC JimiC requested a review from a team June 12, 2018 12:12
@JimiC JimiC force-pushed the code-climate branch 5 times, most recently from f4f98bd to 5dfd3a1 Compare June 12, 2018 13:53
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #1624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1624   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          50      50           
  Lines        2848    2848           
  Branches      138     138           
======================================
  Hits         2848    2848

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60581b...2082967. Read the comment docs.

.codeclimate.yml Outdated
MD013:
enabled: false
MD036:
enabled: false
Copy link
Member

@jens1o jens1o Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps explain in a brief comment what those rules define?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those are explained in the markdownlint docs.

@JimiC JimiC force-pushed the code-climate branch 2 times, most recently from 49bb2a2 to 06a17cd Compare June 13, 2018 08:39
@JimiC JimiC requested a review from a team June 13, 2018 09:25
@jens1o
Copy link
Member

jens1o commented Jun 13, 2018

It is very, like, verbose. :/

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2018

Code Climate has analyzed commit 2082967 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 9

View more on Code Climate.

@robertohuertasm robertohuertasm merged commit 24cc09a into vscode-icons:master Jun 17, 2018
@JimiC JimiC deleted the code-climate branch June 17, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants