Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish stage in CI #1627

Merged
merged 2 commits into from
Jun 17, 2018
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jun 13, 2018

This PR automates the publication process.

Steps:

  • The member constructs the CHANGELOG.
  • The member performs locally npm version <version> --no-git-tag-version.
  • The member submits the PR for approval.
  • Upon approval from another member, the member merges the PR.
  • The member pulls the latest commit locally.
  • The member tags the merged commit.
  • The member pushes the tag.
  • CI picks up the tag and does the publication.

Note:

  • member is a member of the @vscode-icons/development team.

Requirements:
@robertohuertasm In order for this to work a secure environment variable MUST be set in travis settings, named VSCE_TOKEN with a value of the vsce publisher token. It's recommended to generate a fresh token, so it lasts longer, as they have a max year long lifetime.

Additionally, the extensionSettings version has been automated. It will always point to the manifest (package.json) version.

@JimiC JimiC added the devops label Jun 13, 2018
@JimiC JimiC added this to the Next milestone Jun 13, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0e7d6a1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1627   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?      50           
  Lines             ?    2849           
  Branches          ?     138           
========================================
  Hits              ?    2849           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/settings/extensionSettings.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7d6a1...12fe551. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2018

Code Climate has analyzed commit 12fe551 and detected 0 issues on this pull request.

View more on Code Climate.

@robertohuertasm
Copy link
Member

Added already the VSCE_TOKEN to Travis

@robertohuertasm robertohuertasm merged commit 4282d69 into vscode-icons:master Jun 17, 2018
@JimiC JimiC deleted the publish-via-CI branch June 17, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants