Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Imba #1862

Merged
merged 6 commits into from Feb 17, 2019
Merged

Conversation

KingDarBoja
Copy link
Member

Fixes #1844

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

I added the V2 provided at the issue but had no idea how to add it to the iconsManifest.

@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #1862 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1862   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          75      75           
  Lines        5625    5625           
  Branches      220     220           
======================================
  Hits         5625    5625
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️
src/iconsManifest/languages.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2b9a8...fb7ad1c. Read the comment docs.

JimiC
JimiC previously requested changes Feb 4, 2019
Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove imba2 icon. The first icon is much better. Also, we need to pass the svg through the Illustrator to adjust the export format.

@robertohuertasm
Copy link
Member

@KingDarBoja are you using Illustrator? I updated the wiki with the settings you should have to use when exporting for screens.

@KingDarBoja
Copy link
Member Author

@KingDarBoja are you using Illustrator? I updated the wiki with the settings you should have to use when exporting for screens.

I do but to be honest, my Illustrator version doesn't have that option since mine is CC (2013) while this feature was introduced in later version (2015).

What I usually do is place the svg on the correct viewbox and edit the xml to minify the code being generated.

@robertohuertasm robertohuertasm added this to the Next milestone Feb 10, 2019
@robertohuertasm robertohuertasm dismissed JimiC’s stale review February 17, 2019 10:36

imba2 has already been removed

@robertohuertasm robertohuertasm merged commit f59236d into vscode-icons:master Feb 17, 2019
@KingDarBoja KingDarBoja deleted the imba-icon branch February 17, 2019 18:22
@ericvida ericvida mentioned this pull request Jan 17, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants