New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Imba #1862
Add support for Imba #1862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1862 +/- ##
======================================
Coverage 100% 100%
======================================
Files 75 75
Lines 5625 5625
Branches 220 220
======================================
Hits 5625 5625
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove imba2
icon. The first icon is much better. Also, we need to pass the svg
through the Illustrator to adjust the export format.
@KingDarBoja are you using |
I do but to be honest, my What I usually do is place the svg on the correct viewbox and edit the xml to minify the code being generated. |
imba2 has already been removed
Fixes #1844
Changes proposed:
I added the V2 provided at the issue but had no idea how to add it to the iconsManifest.