Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for MDX #1895

Merged
merged 4 commits into from Mar 23, 2019
Merged

Conversation

KingDarBoja
Copy link
Member

Fixes #1766

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #1895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          75      75           
  Lines        5474    5474           
  Branches      127     127           
======================================
  Hits         5474    5474
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c90597...84c5ae2. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #1895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          75      75           
  Lines        5474    5474           
  Branches      127     127           
======================================
  Hits         5474    5474
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc164f...e96607a. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Feb 26, 2019

Not sure that the icon will look good on dark themes.

@JimiC JimiC added this to the Next milestone Mar 16, 2019
@robertohuertasm robertohuertasm merged commit 47970d8 into vscode-icons:master Mar 23, 2019
@KingDarBoja KingDarBoja deleted the mdx-icon branch March 23, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants