Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config icon for config files and binary for pdb #190

Merged
merged 1 commit into from
Aug 27, 2016

Conversation

MarcosMeli
Copy link
Contributor

@MarcosMeli MarcosMeli commented Aug 27, 2016

Changes proposed:

  • Add

Things I've done:

  • I've pulled the latest master branch
  • I've run npm install to install all the dependenies
  • I've checked my code, it is clean.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • My pull request is not too big, otherwise I've already squashed it.
  • I've run npm run build to build the extension. (If I had done something with the extension.)

For example web.config in .Net Core projects
Also .pdb files from .Net

For example web.config in .Net Core projects
Also .pdb files from .Net
@jens1o
Copy link
Member

jens1o commented Aug 27, 2016

1.8.2 is coming.

@robertohuertasm robertohuertasm merged commit 9c7ab58 into vscode-icons:master Aug 27, 2016
@robertohuertasm
Copy link
Member

@jens1o, @MarcosMeli I think I'm going to wait... 2 deliveries in less than half an hour is enough. We have lots of new icon requests and it would be nice to deliver some of them in the next release before preparing for integration.

@jens1o
Copy link
Member

jens1o commented Aug 27, 2016

Okey, did you have a eta for the new integration? Can I do something to help you out?

@robertohuertasm
Copy link
Member

Not really, once we have some new icons I will publish the new version. As usual, feel free to grab one of the pending issues. I'll be glad to include all your PRs 😉

@jens1o
Copy link
Member

jens1o commented Aug 27, 2016

Of course, I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants