Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for entities folder #2002

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Apr 21, 2019

References #650

Changes proposed:

  • Add

@JimiC JimiC added this to the Next milestone Apr 21, 2019
@JimiC JimiC requested a review from a team April 21, 2019 12:17
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2002   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8e305...386b516. Read the comment docs.

@vscode-icons vscode-icons deleted a comment from codecov bot Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2002   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0819...3a9c6ce. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2002   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f0819...3a9c6ce. Read the comment docs.

@robertohuertasm robertohuertasm merged commit 15b1826 into vscode-icons:master Apr 21, 2019
@JimiC JimiC deleted the entities branch April 22, 2019 16:35
@alfonmga
Copy link

Screen Shot 2019-12-17 at 2 17 26 AM

Is this icon OK? it shouldn't be red color like models?

@KingDarBoja
Copy link
Member

@alfonmga If you think it is a bug, better open a new issue to address that 👍

@JimiC
Copy link
Member Author

JimiC commented Dec 19, 2019

It doesn't look like one of our folder icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants