Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google cloud platform folder icons #2005

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Update google cloud platform folder icons #2005

merged 2 commits into from
Apr 21, 2019

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Apr 21, 2019

Changes proposed:

  • Add
  • Delete

@JimiC JimiC added this to the Next milestone Apr 21, 2019
@JimiC JimiC requested a review from a team April 21, 2019 13:00
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2005   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8e305...b92c0ea. Read the comment docs.

jens1o
jens1o reviewed Apr 21, 2019
View reviewed changes
Copy link
Member

@jens1o jens1o left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially like the pink background color!

@JimiC
Copy link
Member Author

JimiC commented Apr 21, 2019

I use it whenever I'm not sure what color to use. There are not much purple (pink) icons around. 😸

@vscode-icons vscode-icons deleted a comment from codecov bot Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2005   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efea9d...80e1e9b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #2005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2005   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5914           
  Branches      137     137           
======================================
  Hits         5914    5914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efea9d...80e1e9b. Read the comment docs.

@robertohuertasm robertohuertasm merged commit f2d38bc into vscode-icons:master Apr 21, 2019
@JimiC JimiC deleted the gcp branch April 22, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jens1o jens1o jens1o left review comments

@robertohuertasm robertohuertasm robertohuertasm approved these changes

Assignees
No one assigned
Labels
folder icons
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JimiC @robertohuertasm @jens1o