-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for XQuery #2039
Add support for XQuery #2039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We already have an icon with
icon: 'xml'
. - The icon is missing from the commit.
- All the
extensions
added are already supported by thelanguageid
(https://github.com/DotJoshJohnson/vscode-xml/blob/master/package.json#L212).
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
======================================
Coverage 100% 100%
======================================
Files 78 78
Lines 5948 5948
Branches 138 138
======================================
Hits 5948 5948
Continue to review full report at Codecov.
|
That said. We have to add a test to avoid duplicate declarations. |
I prefer to use a different icon for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. I take it you tested it out for dark and light themes.
Fixes #1888
Changes proposed:
Note: I'm using temporary the xml icon for this one.