Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XQuery #2039

Merged
merged 3 commits into from
May 1, 2019
Merged

Conversation

KingDarBoja
Copy link
Member

Fixes #1888

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Note: I'm using temporary the xml icon for this one.

Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We already have an icon with icon: 'xml'.
  2. The icon is missing from the commit.
  3. All the extensions added are already supported by the languageid (https://github.com/DotJoshJohnson/vscode-xml/blob/master/package.json#L212).

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #2039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2039   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5948    5948           
  Branches      138     138           
======================================
  Hits         5948    5948
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️
src/iconsManifest/languages.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210cbbe...6bfc3a2. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Apr 28, 2019

That said. We have to add a test to avoid duplicate declarations.

@JimiC
Copy link
Member

JimiC commented Apr 28, 2019

I prefer to use a different icon for xquery than the plainxml one. My proposal is the xml icon with a question mark as the overlaying icon.

@JimiC JimiC added this to the Next milestone Apr 28, 2019
Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. I take it you tested it out for dark and light themes.

@robertohuertasm robertohuertasm merged commit 1728a45 into vscode-icons:master May 1, 2019
@KingDarBoja KingDarBoja deleted the xquery-icon branch June 23, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support for XQuery
3 participants