Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the minimum supported editor version #2223

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix the minimum supported editor version #2223

merged 1 commit into from
Sep 3, 2019

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Sep 3, 2019

Fixes #2218

Changes proposed:

  • Fix

We now rely on the vscode version, set in engines property of the package.json manifest to determine the minimum supported vscode version.

@JimiC JimiC added the bug label Sep 3, 2019
@JimiC JimiC added this to the Next milestone Sep 3, 2019
@JimiC JimiC requested a review from a team September 3, 2019 12:09
@robertohuertasm robertohuertasm merged commit c849813 into vscode-icons:master Sep 3, 2019
@JimiC JimiC deleted the min_support_version_fix branch September 4, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
9.4.0
Development

Successfully merging this pull request may close these issues.

Latest version is not supported in 1.26.1
2 participants
@JimiC @robertohuertasm