Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for node v8 #2350

Merged
merged 2 commits into from
Feb 15, 2020
Merged

Drop support for node v8 #2350

merged 2 commits into from
Feb 15, 2020

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Jan 27, 2020 •
edited

Fixes #2345

Changes proposed:

  • Prepare

  • Update dependencies

  • Fix issues

@vscode-icons/development Upon release, a major version bump is required.

@JimiC JimiC requested a review from a team January 27, 2020 13:27
@JimiC JimiC added this to the Next milestone Jan 27, 2020
@JimiC JimiC force-pushed the node_v8_drop branch 3 times, most recently from f93e3e8 to 8dde9c9 Compare January 31, 2020 08:16
KingDarBoja
KingDarBoja previously approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JimiC
Copy link
Member Author

JimiC commented Feb 3, 2020

@KingDarBoja Unfortunately more commits will be pushed as dependencies get updated often. Better approve when we are closer to release.

@KingDarBoja
Copy link
Member

@KingDarBoja Unfortunately more commits will be pushed as dependencies get updated often. Better approve when we are closer to release.

No worries! As long as this is done in a standalone release (major version).

@KingDarBoja KingDarBoja added the dependencies Pull requests that update a dependency file label Feb 5, 2020
@JimiC
Drop support for node v8
d3f3af0 
- Update dependencies
- Fix issues
@robertohuertasm robertohuertasm merged commit fac28b3 into vscode-icons:master Feb 15, 2020
@JimiC JimiC deleted the node_v8_drop branch February 15, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

@KingDarBoja KingDarBoja KingDarBoja left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Drop Support for NodeJS 8
3 participants
@JimiC @KingDarBoja @robertohuertasm