Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge travis matrix and jobs #2375

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Feb 17, 2020

Attempting to merge travis matrix with jobs. Hopefully, this will reinstate the generation of the wiki pages and the docker images.

@JimiC JimiC added the devops label Feb 17, 2020
@JimiC JimiC requested a review from a team February 17, 2020 09:14
@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

@robertohuertasm Could we merge this to see if things resume building?

@robertohuertasm
Copy link
Member

I will change again the flag in travis to use the new beta validation then, which was the one causing all this issue. I'll let you know once it's done. Thanks for the quick fix.

@robertohuertasm
Copy link
Member

I've changed the setting but I'm afraid we will have to wait for our next release to see if this works. Anyway, knowing what it is, I think it will be easy to fix on the spot if this hits us again.

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

We don't need to wait for the next release. Wiki pages and docker images are generated every time we push to master.

@robertohuertasm
Copy link
Member

I meant for the publish workflow, which was failing yesterday.

@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

It was travis messing up. Publish workflow should be operating as normal.

@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

What is bothering me is why the wiki pages and docker images generation have stopped.

@robertohuertasm
Copy link
Member

It was the same issue that was affecting the publish pipeline. All jobs were ignored.

@robertohuertasm
Copy link
Member

So we can assume that if by merging this, wiki and docker pipelines resume, the publish workflow will also work.

@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

Yes.

@robertohuertasm robertohuertasm merged commit 872bfb1 into vscode-icons:master Feb 17, 2020
@JimiC JimiC deleted the travis_merge_matrix_jobs branch February 17, 2020 09:49
@JimiC
Copy link
Member Author

JimiC commented Feb 17, 2020

There you go, wiki pages and docker images generation stages are showing again.

@robertohuertasm
Copy link
Member

Perfect! We're build config validation proof! Thanks for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants