Add support for DVC #2506
Merged
Add support for DVC #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
requested changes
Jun 7, 2020
|
@shubham-saudolla almost perfect, just a little extra work on the svg but I made the change. 🚀 |
KingDarBoja
approved these changes
Jun 8, 2020
|
@KingDarBoja could you elaborate on the changes you made to the svg? I had left a margin of 2 px, but in your changes the margin is 4px. |
The margin has to be 2px for each side and not as total, so the icon size boundaries are actually 28x28. Also, apologies for the edit, misclicked while editing my response. |
robertohuertasm
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2467
Changes proposed:
Resized and added the svg submitted in this comment.