Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawio): support for SVG and PNG-based drawio files #2987

Merged
merged 3 commits into from
May 21, 2022

Conversation

cathaypacific8747
Copy link
Contributor

Changes proposed:

  • Add

Draw.io supports editing *.drawio.png, *.drawio.svg, *.dio.svg, *.dio.png files.

Copy link
Contributor

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your lints (and my local tests!) failed on this one.
Make sure to simplify - and test locally!

src/iconsManifest/supportedExtensions.ts Outdated Show resolved Hide resolved
cathaypacific8747 and others added 2 commits April 23, 2022 20:13
Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️

@robertohuertasm robertohuertasm changed the title Add support for SVG and PNG-based drawio files feat(drawio): support for SVG and PNG-based drawio files May 21, 2022
@robertohuertasm robertohuertasm merged commit f4613a3 into vscode-icons:master May 21, 2022
@robertohuertasm robertohuertasm added this to the Next milestone May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants