Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): add Rome icon #3177

Merged
merged 3 commits into from Jan 23, 2023
Merged

feat(icon): add Rome icon #3177

merged 3 commits into from Jan 23, 2023

Conversation

damianstasik
Copy link
Contributor

Adds icons for Rome configuration

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

robertohuertasm
robertohuertasm reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I'll review the icons because I think they could be a little big bigger. Not sure if they respect the 2px margin.

@robertohuertasm robertohuertasm added this to the Backlog milestone Jan 21, 2023
@robertohuertasm robertohuertasm self-assigned this Jan 21, 2023
@robertohuertasm robertohuertasm added file icons needs icon rework The icon doesn't follow the guidelines labels Jan 21, 2023
robertohuertasm
robertohuertasm approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon reworked

@robertohuertasm robertohuertasm modified the milestones: Backlog, Next Jan 23, 2023
@robertohuertasm robertohuertasm removed the needs icon rework The icon doesn't follow the guidelines label Jan 23, 2023
@robertohuertasm robertohuertasm merged commit a2ac2b0 into vscode-icons:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

Assignees

@robertohuertasm robertohuertasm

Labels
file icons
Projects
None yet
Milestone
12.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damianstasik @robertohuertasm