Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx): update jsx to framework-agnostic logo #3240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

va3y
Copy link

@va3y va3y commented Feb 23, 2023

Addresses #2776

This PR replaces React icon for framework-agnostic JSX/TSX text. The used color is the same as for normal js/ts icons.

Many people use React and JSX, so I'll appreciate feedback from the community and maintainers about the idea.

What also bugs me is that vscode internally treats jsx as javascriptreact, and it can be seen in a language-selection window:

This maybe will needed to be addressed in the future, but I think replacing default icon is already a good step. This PR doesn't replace default namings in INativeLanguageCollection

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@thetarnav
Copy link

thetarnav commented Feb 23, 2023

For context, the language name for .jsx and .tsx was recently changed in vscode:
issue: microsoft/vscode#138285
PR: microsoft/vscode#168368

@Hacksore
Copy link
Contributor

Including an example of all files togther to compare, I like this!

image

@hiteacheryouare
Copy link

Will there at least be a configuration option to keep it as the current react icon?

@JimiC
Copy link
Member

JimiC commented Aug 6, 2023

@vscode-icons/development This makes total sense to me, since JSX and TSX is being used outside React itself. What we can do, to keep backwards compatibility, is to include this into the icon selection mechanism (you know, the old/new icons selector).

If we go down that path we will have to replace this RP but keep the icons.

@robertohuertasm robertohuertasm added this to the Backlog milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants