feat(jsx): update jsx to framework-agnostic logo #3240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2776
This PR replaces React icon for framework-agnostic JSX/TSX text. The used color is the same as for normal js/ts icons.
Many people use React and JSX, so I'll appreciate feedback from the community and maintainers about the idea.
What also bugs me is that vscode internally treats jsx as
![](https://camo.githubusercontent.com/b6d8df6714f0040ad6a2d4513ce0ef0e2f107533b2495c4167e04e709057fbe3/68747470733a2f2f692e696d6775722e636f6d2f774d664e6b6c712e706e67)
javascriptreact
, and it can be seen in a language-selection window:This maybe will needed to be addressed in the future, but I think replacing default icon is already a good step. This PR doesn't replace default namings in
INativeLanguageCollection
Changes proposed: