Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): add juice icon #3419

Merged
merged 5 commits into from Jan 14, 2024
Merged

Conversation

DevVali
Copy link
Contributor

@DevVali DevVali commented Jan 14, 2024

This adds the Juice logo (a template engine for https://github.com/Lemon-Framework).

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@DevVali
Copy link
Contributor Author

DevVali commented Jan 14, 2024

I could not make the files smaller than 8 kB for this.

@robertohuertasm
Copy link
Member

I couldn't find any extension exposing the juice language id. If that's the case, there's no need to add the language id.

@robertohuertasm
Copy link
Member

Optimized it down to 5.6Kb

@robertohuertasm
Copy link
Member

Optimized down to 713 bytes

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️I optimized the icon and removed the language id.

@robertohuertasm robertohuertasm added this to the 12.7.0 milestone Jan 14, 2024
@DevVali
Copy link
Contributor Author

DevVali commented Jan 14, 2024

I couldn't find any extension exposing the juice language id. If that's the case, there's no need to add the language id.

Is that field for a VSCode extension if I understand correctly?

@robertohuertasm robertohuertasm merged commit dcfdd20 into vscode-icons:master Jan 14, 2024
16 checks passed
@robertohuertasm
Copy link
Member

Let's say that I build a Lemon/Juice extension that would support the framework somehow. I, as the extension creator, would declare a language id in the package.json and would be able to define which extensions are supported. By doing this, the vscode-icons extension would show the icon for the extensions that the lemon extension defines. There would be no need to keep maintaining the list of file extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants