Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .yarnclean to matches #382

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Conversation

wagerfield
Copy link
Contributor

Added .yarnclean extension matching.

Sorry this wasn't in my last PR...I didn't know about it!

Details here.

Copy link
Member

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, but just a note. You don't need to modify the icons.json file as it will be automatically generated when building. 😉

@robertohuertasm robertohuertasm merged commit 23cedb3 into vscode-icons:master Oct 12, 2016
@jens1o
Copy link
Member

jens1o commented Oct 12, 2016

I think he build it himself @robertohuertasm

@wagerfield
Copy link
Contributor Author

@robertohuertasm good to know—I tried to figure out what files I was supposed to modify, but it wasn't that obvious, so I just searched the project for other files to see where they were defined. Perhaps elaborate a little more in the contributing section of the README?

Thanks for the rapid merges 😃

@wagerfield
Copy link
Contributor Author

@robertohuertasm would it be possible to publish a new release with the yarn icons included?

...I'm keen to see them in VSCode 😃

@robertohuertasm
Copy link
Member

@wagerfield you got it. 3.0.5 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants