Fix declarations of supported file extensions and filenames. #501
Conversation
| @@ -96,9 +96,9 @@ exports.extensions = { | |||
| { icon: 'image', extensions: ['jpeg', 'jpg', 'gif', 'png', 'bmp', 'ico'] }, | |||
| { icon: 'ionic', extensions: ['ionic.project'], filename: true }, | |||
| { icon: 'ionic', extensions: ['ionic.config.json'], filename: true }, | |||
| { icon: 'jade', extensions: ['jade', 'pug', 'tag'] }, | |||
There was a problem hiding this comment.
It's already declared in riot and creates a conflict.
There was a problem hiding this comment.
Extensions that collide should be studied. Some can be solved using languageIds. @JimiC you removed prolog language in another PR, which is not right, as languageIds can be added via plugins. In the case of Prolog you can find the extension here and if you see their contribution point you'll see that the id of prolog was correct.
There was a problem hiding this comment.
Right! Restoring and commit again.
There was a problem hiding this comment.
Regarding the tag extension, I can't find anything to justify its presence in two places.
There was a problem hiding this comment.
Cool. Yes, I only see a Riot extension. Any language extension for Jade/Pug... so let's removed as you originally intended. 👍
|
@robertohuertasm Shouldn't the extensions marked with language support not be present in the |
| { icon: 'ng2_service_js', extensions: ['.service.js'], svg: true }, | ||
| { icon: 'ng2_module_ts', extensions: ['.module.ts'], svg: true }, | ||
| { icon: 'ng2_module_js', extensions: ['.module.js'], svg: true }, | ||
| { icon: 'ng2_component_ts', extensions: ['.component.ts'], filename: true, svg: true }, |
There was a problem hiding this comment.
Why the filename property if this is just an extension?
There was a problem hiding this comment.
Seems you are correct. The test was complaining... and head was buzzing. Will revise.
| @@ -96,9 +96,9 @@ exports.extensions = { | |||
| { icon: 'image', extensions: ['jpeg', 'jpg', 'gif', 'png', 'bmp', 'ico'] }, | |||
| { icon: 'ionic', extensions: ['ionic.project'], filename: true }, | |||
| { icon: 'ionic', extensions: ['ionic.config.json'], filename: true }, | |||
| { icon: 'jade', extensions: ['jade', 'pug', 'tag'] }, | |||
There was a problem hiding this comment.
Extensions that collide should be studied. Some can be solved using languageIds. @JimiC you removed prolog language in another PR, which is not right, as languageIds can be added via plugins. In the case of Prolog you can find the extension here and if you see their contribution point you'll see that the id of prolog was correct.
|
Extensions for |
|
@JimiC, regarding the question about language support and extensions, for me it makes sense to have both or at least support both cases, that way if the language support doesn't support (redundance here, sorry) some of the extensions, we don't have to wait or beg the author to implement them in their language extension. Ideally, we shouldn't have to need this duplicity but this is not always perfect so that's why I kept the dual functionality. |
|
@robertohuertasm Yeah, I figured that out after doing some tests, but forgot to comment on my comment. Sorry. |
|
If this PR is OK you can merge it. I'm going to adjust #502 accordingly. |
Writing some more tests revealed some bugs we have in
supportedExtensions.