Improve language ids support. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the use of the extension declaration redundant and adds support for the example generator.
|
We also need to explore what other extensions are supported (besides the default) for those with |
jens1o
approved these changes
Dec 14, 2016
| { icon: 'cshtml', extensions: ['cshtml'] }, | ||
| { icon: 'csproj', extensions: ['csproj'] }, | ||
| { icon: 'css', extensions: ['css'], languages: [languages.css] }, | ||
| { icon: 'css', extensions: [], languages: [languages.css] }, |
There was a problem hiding this comment.
maybe we don't need to have the extensions array defined in them?
There was a problem hiding this comment.
It stays there for 2 reasons:
- in case there is another extension that has the same icon.
- schema consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the use of the extension declaration redundant and adds support for the example generator.