Add cmake icon #555
Merged
Add cmake icon #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon is applied to these files: - CMakeLists.txt - CMakeCache.txt - *.cmake
JimiC
approved these changes
Dec 19, 2016
| @@ -45,6 +45,7 @@ exports.extensions = { | |||
| { icon: 'coffeescript', extensions: ['coffee'] }, | |||
| { icon: 'config', extensions: ['env', 'ini', 'makefile', 'config', 'conf', 'cfg'] }, | |||
| { icon: 'config', extensions: ['makefile', '.env.example'], filename: true }, | |||
| { icon: 'cmake', extensions: ['CMakeCache.txt', 'CMakeLists.txt', '.cmake'], filename: true, svg: true }, | |||
There was a problem hiding this comment.
Can you order it alphabetically? 😉
There was a problem hiding this comment.
Oops ! I thought it was but it seems I was tired...
Fixed !
|
@jens1o what's the problem? |
robertohuertasm
approved these changes
Dec 19, 2016
|
I just looked after the differences in the line deleted and the line added.... There was no difference between them. Until I realized the order itself had been changed ^^ |
|
Guys, the ordering is trivial. The build process assures that the list is sorted. |
|
But it makes the file more readable, isn't it? |
|
It's for readability purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Things I've done:
The cmake icon is applied to these files: