-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more contrast for typings folder #604
Conversation
I would really appreciate if any alternative icons would be added as another version (i.e |
But the point of this PR is precisely make these ones a substitution of the default ones. I've tested them and I think the |
The point of all the work I've done was to have some art rules and guidelines from which we create the icons. Now if some ain't that pretty an alternative can be submitted as v2. Ain't that the point of the new configurable icons feature? |
Clearly we have a different vision on this matter. Guidelines are ok but they are not a rule of thumb that must be followed eyes blinded. Even more when we're dealing with art. It's obvious that color combination was not working. Why deploying a default icon that it's not working even the user has the ability to change it at will? For me, it's more important to provide icons that work than icons that follow the guidelines. |
Fine. I can delete the guide I wrote then. |
Don't be so drastic . I'm not saying that we must get rid of the guidelines. Of course it's a fantastic tool and I'm not trying to undervalue your great work. What I'm saying is that we must apply common sense here. If the result of a specific icon built by following the guideline it's not working as expected then it's licit to change it to make it work. I'm not willing to provide default icons that are not working ok, that's all. |
@robertohuertasm On another note: All icons are getting exported using |
Agreed to publish current as v2. |
Fixes #603
Changes proposed:
Things I've done: