Add support for Gulp file with Babel #866
Conversation
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 40
Lines 1887 1887
Branches 92 92
=====================================
Hits 1887 1887
Continue to review full report at Codecov.
|
| @@ -158,6 +158,7 @@ export const extensions: IFileCollection = { | |||
| { icon: 'groovy2', extensions: [], languages: [languages.groovy], format: FileFormat.svg, disabled: true }, | |||
| { icon: 'grunt', extensions: ['gruntfile.js'], filename: true, format: FileFormat.svg }, | |||
| { icon: 'gulp', extensions: ['gulpfile.js'], filename: true, format: FileFormat.svg }, | |||
| { icon: 'gulp', extensions: ['gulpfile.babel.js'], filename: true, format: FileFormat.svg }, | |||
There was a problem hiding this comment.
do not redefine the extension, just add it the line above like this:
{ icon: 'gulp', extensions: ['gulpfile.js', 'gulpfile.babel.js'], filename: true, format: FileFormat.svg },
|
@mamadoo could you rebase your branch with our master? I'll merge it after that. Thanks for your PR! |
|
We can do that too @robertohuertasm ? |
|
Yes, I know but I prefer users do that if possible. |
|
Okay. |
|
I don't clone the forked repository in my computer at first. I change this file directly in github online and the create the PR for that. I don't know how to rebase forked account directly in github online (i just know in command line). |
|
@mamadoo What you did is equally fine. |
Changes proposed:
Things I've done: