-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for zh-CN #871
added support for zh-CN #871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 41 +1
Lines 1887 1889 +2
Branches 92 92
=====================================
+ Hits 1887 1889 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is incomplete. You need to add an in code reference to the provided language. Additionally, we would like you to also provide translation for the commands
via a package.nls.zh-cn.json
file.
I had to remove the double quotation for zh-CN in the langResourceCollection.ts file otherwise it gives me an error. is there a better way to do it? |
04dc968
to
4369530
Compare
@iFun I fixed the issues for you. One question though. Isn't the |
4369530
to
469b43b
Compare
@JimiC period in Chinese is “。” which is ugly and usually not in use. So if there is only one sentence the common practice is to avoid using “。”. “。” is only be used in long paragraph where sentence separation is necessary such as README. |
@iFun That's what I read when searching about punctuation marks usage in the Chinese language, but thought to ask to be sure. Thanks for the info. |
Reference #526
Changes proposed:
Things I've done:
let me know if there is any changes needed in this pr