Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for zh-CN #871

Merged
merged 6 commits into from
Apr 22, 2017

Conversation

iFun
Copy link
Contributor

@iFun iFun commented Apr 16, 2017

Reference #526
Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

let me know if there is any changes needed in this pr

@codecov
Copy link

codecov bot commented Apr 16, 2017

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #871   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     41    +1     
  Lines        1887   1889    +2     
  Branches       92     92           
=====================================
+ Hits         1887   1889    +2
Impacted Files Coverage Δ
src/i18n/langResourceCollection.ts 100% <ø> (ø) ⬆️
src/i18n/langResources/index.ts 100% <100%> (ø) ⬆️
src/i18n/index.ts 100% <100%> (ø) ⬆️
src/i18n/langResources/lang.zh-cn.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400e78b...22b0212. Read the comment docs.

Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is incomplete. You need to add an in code reference to the provided language. Additionally, we would like you to also provide translation for the commands via a package.nls.zh-cn.json file.

@iFun
Copy link
Contributor Author

iFun commented Apr 18, 2017

I had to remove the double quotation for zh-CN in the langResourceCollection.ts file otherwise it gives me an error. is there a better way to do it?

@JimiC JimiC force-pushed the feature-simplified-chinese branch from 04dc968 to 4369530 Compare April 18, 2017 08:07
@JimiC
Copy link
Member

JimiC commented Apr 18, 2017

@iFun I fixed the issues for you. One question though. Isn't the period punctuation mark (.) used in Chinese?

@JimiC JimiC force-pushed the feature-simplified-chinese branch from 4369530 to 469b43b Compare April 18, 2017 08:11
@iFun
Copy link
Contributor Author

iFun commented Apr 18, 2017

@JimiC period in Chinese is “。” which is ugly and usually not in use. So if there is only one sentence the common practice is to avoid using “。”. “。” is only be used in long paragraph where sentence separation is necessary such as README.

@JimiC
Copy link
Member

JimiC commented Apr 18, 2017

@iFun That's what I read when searching about punctuation marks usage in the Chinese language, but thought to ask to be sure. Thanks for the info.

@robertohuertasm robertohuertasm merged commit 07aeaf2 into vscode-icons:master Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants