Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zh-cn translations #980

Merged
merged 3 commits into from
May 31, 2017
Merged

Improve zh-cn translations #980

merged 3 commits into from
May 31, 2017

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented May 31, 2017

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • My pull request fixes an issue, I referenced the issue.

Some improvements of zh-cn translations.
Also, fixed code typo.

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #980 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #980   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          44     44           
  Lines        2110   2110           
  Branches       99     99           
=====================================
  Hits         2110   2110
Impacted Files Coverage Δ
src/i18n/langResources/lang.en.ts 100% <ø> (ø) ⬆️
src/i18n/langResources/lang.es.ts 100% <ø> (ø) ⬆️
src/i18n/langResources/lang.zh-cn.ts 100% <ø> (ø) ⬆️
src/i18n/langResources/lang.de.ts 100% <ø> (ø) ⬆️
src/i18n/langResources/lang.it.ts 100% <ø> (ø) ⬆️
src/models/i18n/langResourceKeys.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4eec0...a853c2c. Read the comment docs.

Copy link
Member

@JimiC JimiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch of the typo.

@robertohuertasm robertohuertasm merged commit 7acb4e7 into vscode-icons:master May 31, 2017
@robertohuertasm
Copy link
Member

@g-plane , thanks for the PR!

@g-plane
Copy link
Contributor Author

g-plane commented May 31, 2017

You're welcome.

@robertohuertasm robertohuertasm modified the milestone: Next Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants