-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more requested folder icons. #981
Conversation
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 44 44
Lines 2110 2110
Branches 99 99
=====================================
Hits 2110 2110
Continue to review full report at Codecov.
|
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_script</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#686868"/><path d="M16.012,10H27.654a3.141,3.141,0,0,1,1.913.817A4.73,4.73,0,0,1,30.93,13.65c.03.212.048.425.07.639v.368a.7.7,0,0,1-.306.491,1.2,1.2,0,0,1-.678.1H28.379q-.009,6.069,0,12.138a3.574,3.574,0,0,1-.532,1.888A3.629,3.629,0,0,1,25.96,30.8a4.359,4.359,0,0,1-.972.2H13.92a4.035,4.035,0,0,1-2.216-.8,4.481,4.481,0,0,1-1.6-2.7c-.054-.258-.076-.522-.107-.784V26.3a.728.728,0,0,1,.3-.454,1.11,1.11,0,0,1,.639-.1h1.681V13.606A3.588,3.588,0,0,1,13.744,11a3.648,3.648,0,0,1,2.268-1" style="fill:#333"/><path d="M14.092,12.777a4.57,4.57,0,0,0-.154,1.653V25.748c2.434.006,4.868,0,7.3,0a.65.65,0,0,1,.587.433,2.992,2.992,0,0,1,.051.572,3.417,3.417,0,0,0,1.038,2.278,2.662,2.662,0,0,0,1.806.652,2.3,2.3,0,0,0,2.338-2.252q0-.024,0-.048V13.889a1.953,1.953,0,0,1,.03-.466,4.574,4.574,0,0,1,.569-1.4,2.212,2.212,0,0,1,.673-.719q-6.051-.007-12.1,0A2.307,2.307,0,0,0,14.092,12.777Z" style="fill:gray"/><path d="M18.008,16.819a.7.7,0,0,1,.607-.258.656.656,0,0,1,.582.723q0,.028-.009.056c-.045.256-.268.415-.437.591-.638.641-1.293,1.265-1.924,1.912.654.666,1.327,1.313,1.986,1.974a1.046,1.046,0,0,1,.375.53.658.658,0,0,1-.466.761.649.649,0,0,1-.629-.158c-.885-.865-1.757-1.744-2.64-2.611a.665.665,0,0,1-.043-.939l.005-.006Q16.709,18.1,18.008,16.819Z" style="fill:#333"/><path d="M21.812,17.176a.658.658,0,0,1,.574-.609.672.672,0,0,1,.547.188q1.3,1.286,2.595,2.573a.674.674,0,0,1,.011,1.043q-1.258,1.244-2.512,2.491a.767.767,0,0,1-.475.277.656.656,0,0,1-.719-.479.664.664,0,0,1,.182-.646c.724-.722,1.456-1.434,2.174-2.162-.711-.713-1.43-1.418-2.146-2.126A.687.687,0,0,1,21.812,17.176Z" style="fill:#333"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the script folder modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad!
icons/folder_type_private.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_private</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#c15368"/><path d="M20.4,10A10.5,10.5,0,1,0,30.9,20.5,10.5,10.5,0,0,0,20.4,10Zm0,18.375a7.862,7.862,0,0,1-6.41-12.432L24.958,26.911A7.826,7.826,0,0,1,20.4,28.375Zm6.411-3.318L15.843,14.09A7.862,7.862,0,0,1,26.811,25.057Z" style="fill:#d80027"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The forbidden symbol seems too strong for me. I would use some spy or glasses as in the browsers or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose this icon on 2 criteria.
- The simplicity of the icon. It was the most flat I found. At first, I had also the
public
icon in the background but because it was not distinguishable I removed it. - The
brain wiring
as you so call it. I believe this icon serves its purpose.
My suggestions are:
- Let's release it and await user feedback.
or - Submit your version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons/folder_type_public.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_public</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#00a23c"/><path d="M22.573,16.294a3.816,3.816,0,0,1,1.776,2.835,3.079,3.079,0,1,0-1.776-2.835ZM20.555,22.6a3.08,3.08,0,1,0-3.08-3.08A3.08,3.08,0,0,0,20.555,22.6Zm1.306.21H19.248A3.948,3.948,0,0,0,15.3,26.753v3.2l.008.05.22.069a17.95,17.95,0,0,0,5.362.865,11.007,11.007,0,0,0,4.682-.879l.206-.1H25.8v-3.2A3.947,3.947,0,0,0,21.861,22.81Zm5.1-3.179H24.364a3.8,3.8,0,0,1-1.171,2.644,4.686,4.686,0,0,1,3.347,4.484v.985a10.612,10.612,0,0,0,4.133-.868l.206-.1H30.9v-3.2A3.948,3.948,0,0,0,26.957,19.63Zm-11.806-.21a3.059,3.059,0,0,0,1.638-.475,3.812,3.812,0,0,1,1.433-2.431c0-.058.009-.115.009-.173a3.08,3.08,0,1,0-3.079,3.079Zm2.766,2.853a3.8,3.8,0,0,1-1.171-2.629c-.1-.007-.191-.015-.289-.015H13.843A3.948,3.948,0,0,0,9.9,23.573v3.2l.008.049.22.069a18.489,18.489,0,0,0,4.441.835v-.965A4.687,4.687,0,0,1,17.917,22.274Z"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons/folder_type_private.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_private</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#c15368"/><path d="M20.4,10A10.5,10.5,0,1,0,30.9,20.5,10.5,10.5,0,0,0,20.4,10Zm0,18.375a7.862,7.862,0,0,1-6.41-12.432L24.958,26.911A7.826,7.826,0,0,1,20.4,28.375Zm6.411-3.318L15.843,14.09A7.862,7.862,0,0,1,26.811,25.057Z" style="fill:#d80027"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icons/folder_type_server.svg
Outdated
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_server</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#53c1b6"/><path d="M21.283,10.952V12.27a.623.623,0,0,1,.141,0l8.6,1.719a.721.721,0,0,1-.141,1.429.767.767,0,0,1-.143-.015l-8.453-1.69v.8a.7.7,0,0,1,.116,0l8.6,1.4a.722.722,0,0,1-.116,1.434.739.739,0,0,1-.117-.009l-8.48-1.382v.636a.628.628,0,0,1,.1-.007l8.6,1.25a.721.721,0,0,1-.1,1.435.79.79,0,0,1-.1-.007l-8.492-1.235v.727a.613.613,0,0,1,.085-.008l8.6,1.01a.722.722,0,0,1-.084,1.438c-.028,0-.055,0-.084,0l-8.514-1v10H30.9V12.876Zm8.013,12.5a.6.6,0,1,1,.6-.6A.6.6,0,0,1,29.3,23.456Z" style="fill:#4a9ad1"/><path d="M13.607,21.13c.175-.009.351-.015.525-.015,2.268,0,4.709.773,4.709,2.47v5.972a1.624,1.624,0,0,1-.129.632H21.3V10.952l-7.7,3.848Z" style="fill:#4a9ad1"/><path d="M14.1,31.069c2.07,0,3.75-.656,3.75-1.466V28.536a3.952,3.952,0,0,1-.578.287l-.059.024a8.84,8.84,0,0,1-3.113.509,8.816,8.816,0,0,1-3.113-.509l-.059-.024a3.952,3.952,0,0,1-.578-.287V29.6C10.35,30.413,12.03,31.069,14.1,31.069Z" style="fill:#4a9ad1"/><path d="M11.3,28.444a5.876,5.876,0,0,0,.979.279,9.82,9.82,0,0,0,3.642,0,5.877,5.877,0,0,0,.979-.279c.7-.274.95-.578.95-.753V26.415a4.03,4.03,0,0,1-.637.311,8.841,8.841,0,0,1-3.113.505,8.841,8.841,0,0,1-3.113-.507,4.076,4.076,0,0,1-.637-.311v1.277C10.35,27.866,10.6,28.169,11.3,28.444Z" style="fill:#4a9ad1"/><path d="M11.3,26.32a7.964,7.964,0,0,0,2.8.449,7.964,7.964,0,0,0,2.8-.449c.7-.274.95-.578.95-.753V24.229a3.9,3.9,0,0,1-.784.4,8.391,8.391,0,0,1-2.966.49,8.416,8.416,0,0,1-2.966-.489,3.869,3.869,0,0,1-.784-.406v1.336C10.35,25.743,10.6,26.046,11.3,26.32Z" style="fill:#4a9ad1"/><ellipse cx="14.1" cy="23.096" rx="3.75" ry="1.466" style="fill:#4a9ad1"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertohuertasm Question: Is your screenshot the thing before or after the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think then the contrast is a little bit too low. I think there should be some more contrast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my screenshots are after the modification. In order to see the original you can take a look at the svg.
@robertohuertasm Feel free to push your icons on the branch. |
b10e9b5
to
394f56a
Compare
I've modified the following icons to make the icons more visible:
Great work @JimiC. If you feel that you don't like any of the changed files please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some better flat icon for the tools
folder? Imo it doesn't fit with our guidelines.
(But I'm fine with it, personal opinion.)
@robertohuertasm Whatever you are fine with, I'm OK. |
4be61ba
to
2ccd309
Compare
2ccd309
to
7f5e1f8
Compare
Changed the tools and lib icons to flat ones. |
Relates to #650
Changes proposed:
List of added folder icons:
Also changed the coloring of the background folder of the
script
folder icon to improve visibility in light themes.