Add more requested folder icons. #981

JimiC · 2017-05-31T11:01:48Z

Relates to #650

Changes proposed:

Add

List of added folder icons:

client
include
plugin
private
public
server
tools

Also changed the coloring of the background folder of the script folder icon to improve visibility in light themes.

codecov · 2017-05-31T11:08:12Z

Codecov Report

Merging #981 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #981   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          44     44           
  Lines        2110   2110           
  Branches       99     99           
=====================================
  Hits         2110   2110

Impacted Files	Coverage Δ
src/icon-manifest/supportedFolders.ts	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455c6f0...ae91e63. Read the comment docs.

robertohuertasm · 2017-06-02T11:25:27Z

icons/folder_type_script.svg

Why is the script folder modified?

Please see PR description.

robertohuertasm · 2017-06-02T11:26:18Z

icons/folder_type_private.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_private</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#c15368"/><path d="M20.4,10A10.5,10.5,0,1,0,30.9,20.5,10.5,10.5,0,0,0,20.4,10Zm0,18.375a7.862,7.862,0,0,1-6.41-12.432L24.958,26.911A7.826,7.826,0,0,1,20.4,28.375Zm6.411-3.318L15.843,14.09A7.862,7.862,0,0,1,26.811,25.057Z" style="fill:#d80027"/></svg>


The forbidden symbol seems too strong for me. I would use some spy or glasses as in the browsers or something like that.

I chose this icon on 2 criteria.

The simplicity of the icon. It was the most flat I found. At first, I had also the public icon in the background but because it was not distinguishable I removed it.

The brain wiring as you so call it. I believe this icon serves its purpose.

My suggestions are:

Let's release it and await user feedback.
or

Submit your version.

I'd change the folder color to #913E4E to improve the contrast with the forbidden icon

robertohuertasm · 2017-06-03T18:00:05Z

icons/folder_type_public.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_public</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#00a23c"/><path d="M22.573,16.294a3.816,3.816,0,0,1,1.776,2.835,3.079,3.079,0,1,0-1.776-2.835ZM20.555,22.6a3.08,3.08,0,1,0-3.08-3.08A3.08,3.08,0,0,0,20.555,22.6Zm1.306.21H19.248A3.948,3.948,0,0,0,15.3,26.753v3.2l.008.05.22.069a17.95,17.95,0,0,0,5.362.865,11.007,11.007,0,0,0,4.682-.879l.206-.1H25.8v-3.2A3.947,3.947,0,0,0,21.861,22.81Zm5.1-3.179H24.364a3.8,3.8,0,0,1-1.171,2.644,4.686,4.686,0,0,1,3.347,4.484v.985a10.612,10.612,0,0,0,4.133-.868l.206-.1H30.9v-3.2A3.948,3.948,0,0,0,26.957,19.63Zm-11.806-.21a3.059,3.059,0,0,0,1.638-.475,3.812,3.812,0,0,1,1.433-2.431c0-.058.009-.115.009-.173a3.08,3.08,0,1,0-3.079,3.079Zm2.766,2.853a3.8,3.8,0,0,1-1.171-2.629c-.1-.007-.191-.015-.289-.015H13.843A3.948,3.948,0,0,0,9.9,23.573v3.2l.008.049.22.069a18.489,18.489,0,0,0,4.441.835v-.965A4.687,4.687,0,0,1,17.917,22.274Z"/></svg>


I'd suggest to change the color of the user icon to #AAFFA2

robertohuertasm · 2017-06-03T18:04:39Z

icons/folder_type_private.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_private</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#c15368"/><path d="M20.4,10A10.5,10.5,0,1,0,30.9,20.5,10.5,10.5,0,0,0,20.4,10Zm0,18.375a7.862,7.862,0,0,1-6.41-12.432L24.958,26.911A7.826,7.826,0,0,1,20.4,28.375Zm6.411-3.318L15.843,14.09A7.862,7.862,0,0,1,26.811,25.057Z" style="fill:#d80027"/></svg>


I'd change the folder color to #913E4E to improve the contrast with the forbidden icon

robertohuertasm · 2017-06-03T18:12:48Z

icons/folder_type_server.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_server</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#53c1b6"/><path d="M21.283,10.952V12.27a.623.623,0,0,1,.141,0l8.6,1.719a.721.721,0,0,1-.141,1.429.767.767,0,0,1-.143-.015l-8.453-1.69v.8a.7.7,0,0,1,.116,0l8.6,1.4a.722.722,0,0,1-.116,1.434.739.739,0,0,1-.117-.009l-8.48-1.382v.636a.628.628,0,0,1,.1-.007l8.6,1.25a.721.721,0,0,1-.1,1.435.79.79,0,0,1-.1-.007l-8.492-1.235v.727a.613.613,0,0,1,.085-.008l8.6,1.01a.722.722,0,0,1-.084,1.438c-.028,0-.055,0-.084,0l-8.514-1v10H30.9V12.876Zm8.013,12.5a.6.6,0,1,1,.6-.6A.6.6,0,0,1,29.3,23.456Z" style="fill:#4a9ad1"/><path d="M13.607,21.13c.175-.009.351-.015.525-.015,2.268,0,4.709.773,4.709,2.47v5.972a1.624,1.624,0,0,1-.129.632H21.3V10.952l-7.7,3.848Z" style="fill:#4a9ad1"/><path d="M14.1,31.069c2.07,0,3.75-.656,3.75-1.466V28.536a3.952,3.952,0,0,1-.578.287l-.059.024a8.84,8.84,0,0,1-3.113.509,8.816,8.816,0,0,1-3.113-.509l-.059-.024a3.952,3.952,0,0,1-.578-.287V29.6C10.35,30.413,12.03,31.069,14.1,31.069Z" style="fill:#4a9ad1"/><path d="M11.3,28.444a5.876,5.876,0,0,0,.979.279,9.82,9.82,0,0,0,3.642,0,5.877,5.877,0,0,0,.979-.279c.7-.274.95-.578.95-.753V26.415a4.03,4.03,0,0,1-.637.311,8.841,8.841,0,0,1-3.113.505,8.841,8.841,0,0,1-3.113-.507,4.076,4.076,0,0,1-.637-.311v1.277C10.35,27.866,10.6,28.169,11.3,28.444Z" style="fill:#4a9ad1"/><path d="M11.3,26.32a7.964,7.964,0,0,0,2.8.449,7.964,7.964,0,0,0,2.8-.449c.7-.274.95-.578.95-.753V24.229a3.9,3.9,0,0,1-.784.4,8.391,8.391,0,0,1-2.966.49,8.416,8.416,0,0,1-2.966-.489,3.869,3.869,0,0,1-.784-.406v1.336C10.35,25.743,10.6,26.046,11.3,26.32Z" style="fill:#4a9ad1"/><ellipse cx="14.1" cy="23.096" rx="3.75" ry="1.466" style="fill:#4a9ad1"/></svg>


I'd suggest to change the icon color to #00608B to improve contrast and icon definition:

@robertohuertasm Question: Is your screenshot the thing before or after the change?

I think then the contrast is a little bit too low. I think there should be some more contrast.

All my screenshots are after the modification. In order to see the original you can take a look at the svg.

JimiC · 2017-06-03T18:39:58Z

@robertohuertasm Feel free to push your icons on the branch.

robertohuertasm · 2017-06-03T22:52:41Z

I've modified the following icons to make the icons more visible:

Vagrant
Docker
Tools
Server
Public
Private
Plugin
Include

Great work @JimiC. If you feel that you don't like any of the changed files please let me know.

jens1o

Is there some better flat icon for the tools folder? Imo it doesn't fit with our guidelines.

(But I'm fine with it, personal opinion.)

JimiC · 2017-06-04T07:47:45Z

@robertohuertasm Whatever you are fine with, I'm OK.

robertohuertasm · 2017-06-04T08:17:49Z

Changed the tools and lib icons to flat ones.

JimiC requested review from robertohuertasm and jens1o May 31, 2017 11:01

JimiC force-pushed the more_folder_icons branch from f1d42ff to 947e9e2 Compare May 31, 2017 11:54

jens1o approved these changes May 31, 2017

View reviewed changes

robertohuertasm reviewed Jun 2, 2017

View reviewed changes

JimiC added the folder icons label Jun 3, 2017

robertohuertasm reviewed Jun 3, 2017

View reviewed changes

robertohuertasm force-pushed the more_folder_icons branch from b10e9b5 to 394f56a Compare June 3, 2017 22:48

jens1o reviewed Jun 4, 2017

View reviewed changes

robertohuertasm force-pushed the more_folder_icons branch 2 times, most recently from 4be61ba to 2ccd309 Compare June 4, 2017 08:16

JimiC and others added 2 commits June 4, 2017 10:16

Add more requested folder icons.

d4710c4

changes to improve contrast between icons and background

7f5e1f8

robertohuertasm force-pushed the more_folder_icons branch from 2ccd309 to 7f5e1f8 Compare June 4, 2017 08:17

jens1o approved these changes Jun 4, 2017

View reviewed changes

changed server icon

ae91e63

robertohuertasm added this to the Next milestone Jun 4, 2017

robertohuertasm merged commit bb489c8 into vscode-icons:master Jun 4, 2017

JimiC deleted the more_folder_icons branch June 4, 2017 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more requested folder icons. #981

Add more requested folder icons. #981

JimiC commented May 31, 2017 •

edited

codecov bot commented May 31, 2017 •

edited

robertohuertasm Jun 2, 2017

JimiC Jun 2, 2017

robertohuertasm Jun 3, 2017

robertohuertasm Jun 2, 2017 •

edited by JimiC

JimiC Jun 2, 2017 •

edited

robertohuertasm Jun 3, 2017

robertohuertasm Jun 3, 2017

robertohuertasm Jun 3, 2017

robertohuertasm Jun 3, 2017

jens1o Jun 3, 2017

robertohuertasm Jun 3, 2017

jens1o Jun 3, 2017

robertohuertasm Jun 3, 2017

JimiC commented Jun 3, 2017 •

edited

robertohuertasm commented Jun 3, 2017

jens1o left a comment •

edited

JimiC commented Jun 4, 2017

robertohuertasm commented Jun 4, 2017

		@@ -0,0 +1 @@
		<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>folder_type_private</title><path d="M27.5,5.5H18.2L16.1,9.7H4.4V26.5H29.6V5.5Zm0,4.2H19.3l1.1-2.1h7.1Z" style="fill:#c15368"/><path d="M20.4,10A10.5,10.5,0,1,0,30.9,20.5,10.5,10.5,0,0,0,20.4,10Zm0,18.375a7.862,7.862,0,0,1-6.41-12.432L24.958,26.911A7.826,7.826,0,0,1,20.4,28.375Zm6.411-3.318L15.843,14.09A7.862,7.862,0,0,1,26.811,25.057Z" style="fill:#d80027"/></svg>

Add more requested folder icons. #981

Add more requested folder icons. #981

Conversation

JimiC commented May 31, 2017 • edited

codecov bot commented May 31, 2017 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robertohuertasm Jun 2, 2017 • edited by JimiC

Choose a reason for hiding this comment

JimiC Jun 2, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JimiC commented Jun 3, 2017 • edited

robertohuertasm commented Jun 3, 2017

jens1o left a comment • edited

Choose a reason for hiding this comment

JimiC commented Jun 4, 2017

robertohuertasm commented Jun 4, 2017

JimiC commented May 31, 2017 •

edited

codecov bot commented May 31, 2017 •

edited

robertohuertasm Jun 2, 2017 •

edited by JimiC

JimiC Jun 2, 2017 •

edited

JimiC commented Jun 3, 2017 •

edited

jens1o left a comment •

edited