Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to underscore folder in include paths with css supersets #996

Closed
wants to merge 7 commits into from

Conversation

jens1o
Copy link
Member

@jens1o jens1o commented Jun 4, 2017

Changes proposed:

  • Add

image

@codecov
Copy link

codecov bot commented Jun 4, 2017

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #996   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          44     44           
  Lines        2110   2110           
  Branches       99     99           
=====================================
  Hits         2110   2110
Impacted Files Coverage Δ
src/icon-manifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455c6f0...f5860cb. Read the comment docs.

@JimiC
Copy link
Member

JimiC commented Jun 4, 2017

Can you provide any doc or reasoning for this PR?

@jens1o
Copy link
Member Author

jens1o commented Jun 4, 2017

For example here: https://github.com/imperavi/kube

In this repository, and in others, they use it to mark dependencies(that are included in the framework), so not any file is directly at the top but in a clean view.

@robertohuertasm
Copy link
Member

I thought this underscore convention was just for partial files in sass and less and somehow assumed that it had extended to folders too, but I've found #384 and it seems to be a very old issue that still has not been closed.

After googling a little bit for "_sass" and "_scss" I haven't found any official docs about the use of this syntax. I've seen that some projects like Jekyll and Docker make use of it, but I'm under the impression that they use it to remark some kind of prebuild vs final state. And I say so because they also use this convention with _includes , _layouts...

@robertohuertasm robertohuertasm added this to the Next milestone Jun 4, 2017
@JimiC
Copy link
Member

JimiC commented Jun 4, 2017

So if we are to map also underscored folder names (along with the dotted ones) I suggest we add a marking enum mechanism (like we do with language) and generate the mapping internally.

@jens1o
Copy link
Member Author

jens1o commented Jun 4, 2017

I like that idea. (Closing because this will be handled otherwise)

@jens1o jens1o closed this Jun 4, 2017
@jens1o jens1o deleted the jens1o-_scss branch June 4, 2017 14:25
@JimiC JimiC removed this from the Next milestone Jun 4, 2017
@jens1o jens1o mentioned this pull request Jun 7, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants