Improve callAtomic error logging #1110
Conversation
Neovim seems to be completely ignoring any changes made in insert mode, which is causing neovim's buffer to get out of sync with the version of the file in VSCode.
The issue with insert mode changes getting ignored is caused by nvim_buf_set_text not being recognized by an old Neovim version installed on my computer (somewhere around 0.5.0), so make this more obvious by reporting an error if there the Neovim version than the current minimum required version (which is 0.8.0 according to the readme).
The previous bug caused by nvim_buf_set_text not existing on older Neovim could have been noticed if you saw the error messages returned by Neovim, which included an "Invalid method: nvim_buf_set_text" error. Make bugs like this easier to find in the future by correctly logging those Neovim-returned errors. Also silence errors due to nvim_win_close calls since there seem to be several errors mentioning an invalid window ID being passed to it and those errors are currently probably more annoying than helpful.
Make bugs involving old Neovim versions more apparent by running CI on the oldest supported version, so that we don't accidentally end up relying on features introduced in later versions.
|
I don't really understand why the CI is failing. The "extmark display overlay" test is causing the error "nvim_call_function: Vim:E5555: API call: col value outside range", but I can't reproduce that error on my computer. |
|
Thank you for the PR! The error logging changes need a bit more attention (to make sure it won't cause problems, and maybe fix the underlying problems), so I have gone ahead and cherry-picked the simpler changes in #1115. Feel free to keep working on this PR! I'm not sure if the failing test is your fault. |
theol0403
changed the title
|
In most cases, we don't care about the results of |
|
I just discovered that there are so many descriptions. In fact, these are useless and should be deleted. |
|
It's true that most of them aren't relevant, but I don't think it really matters |
I spent a lot of time trying to figure out why this extension and Neovim's view of the current file always seemed to ignore any changes made in insert mode, only to realize that it was caused by my installed Neovim being too old to have
nvim_buf_set_textdefined (which was necessary after #992).This PR makes a few changes to make errors like that easier to discover by:
callAtomic's error handling to actually report all errors to the user (I suspect the old implementation wasn't actually reporting any errors since it seems like it was looking for errors in the wrong place)The extra error reporting in
callAtomicseems to be surfacing some old errors (so far I've found errors in bothnvim_win_closeandnvim_buf_set_name) and I'm not sure whether we should silence those for now or leave them on until they're fixed. For now, I've silencednvim_win_closeerrors but I'm not sure whether that's the right decision.