Issues with rendering blank highlight in VSCode | Leap.nvim #1143
Comments
snacksncode
changed the title
|
Also when a keyword has it's opacity lowered, same happens to the overlay, not sure if this is fixable / intended.
|
|
highlighting is best-effort |
|
I think I'd like to keep this issue open, as it tracks a real disconnect in the highlight parsing code. |
3 tasks
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this issue
Jul 5, 2023
7 tasks
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this issue
Jul 5, 2023
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this issue
Jul 6, 2023
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this issue
Jul 6, 2023
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this issue
Jul 21, 2023
This PR sends visual selections to vscode as real selections. Discussion from vscode-neovim#172. It also converts vscode selections to visual selections. * a fake cursor is created using the extmark api that frees up the primary vscode selection for a proper selection * the `Visual` highlight is not removed to hide the fact that `viw` does not trigger an update to vscode * while waiting for neovim/neovim#19708, `viw` and `C-/` will not update vscode visual selection, so immediately doing something like C-S-F (search in files) will not contain the visual selection. However, since the `Visual` group is still being shown, the issue is minor. * extmarks can now be shown on the last line * VSCodeRange/VSCodeVisual removed feat(cursor)!: remove range-based commands BREAKING-CHANGE: VSCodeNotifyVisual/VSCodeNotifyRange is removed, use VSCodeNotify instead fix(highlight): fix blank extmarks (vscode-neovim#1143) fix(highlight): fix extmarks beyond end of line feat(cursor): send vscode selections to neovim, including intuitive mouse selections fix(cursor): fix rapid typing after entering insert mode feat(cursor): improve performance and flicker fact(cursor): convert multi cursor to lua fix(highlight): wait for document change before creating highlights fact(viewport): use 0-based coords fix(highlight): ignore compound group names, like MatchParenVisual
theol0403
added a commit
that referenced
this issue
Jul 21, 2023
This PR sends visual selections to vscode as real selections. Discussion from #172. It also converts vscode selections to visual selections. * a fake cursor is created using the extmark api that frees up the primary vscode selection for a proper selection * the `Visual` highlight is not removed to hide the fact that `viw` does not trigger an update to vscode * while waiting for neovim/neovim#19708, `viw` and `C-/` will not update vscode visual selection, so immediately doing something like C-S-F (search in files) will not contain the visual selection. However, since the `Visual` group is still being shown, the issue is minor. * extmarks can now be shown on the last line * VSCodeRange/VSCodeVisual removed feat(cursor)!: remove range-based commands BREAKING-CHANGE: `VSCodeNotifyVisual` and `VSCodeNotifyRange` is removed, use `VSCodeNotify` instead fix(highlight): fix blank extmarks (#1143) fix(highlight): fix extmarks beyond end of line feat(cursor)!: send vscode selections to neovim, including intuitive mouse selections (remove mouse setting) fix(typing): fix rapid typing after entering insert mode feat(cursor): improve performance and flicker fact(cursor): convert multi cursor script to lua fix(highlight): wait for document change before creating highlights fact(viewport): use 0-based coords fix(highlight): ignore compound group names, like MatchParenVisual
|
Thank you so much for looking into this @theol0403 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I'm noticing issues with "empty" highlight in VSCode which should block the character underneath. I'm using
leap.nvim. It has some options for highlight colors via:h leap-highlight, but there's no option to set colors for this "empty" highlight cellShowcase
VSCode renders the highlight but you can see the character that is actually in the word, so every highlight pair ends with
las I'm looking for theclassName.Reproduction
leap.nvim...scls<Enter>, this will repeat your last search and will render those empty cells to indicate that you need to press just the first characterIf this issue is not with this extension and I need to ask guys from
leap.nvim, please let me knowThe text was updated successfully, but these errors were encountered: